From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5CXC-0007LG-OE for qemu-devel@nongnu.org; Wed, 17 Jun 2015 08:33:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5CX4-00015Z-0A for qemu-devel@nongnu.org; Wed, 17 Jun 2015 08:33:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5CX3-00015V-Rr for qemu-devel@nongnu.org; Wed, 17 Jun 2015 08:33:29 -0400 Message-ID: <55816915.1020704@redhat.com> Date: Wed, 17 Jun 2015 14:33:25 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1433946024-18439-1-git-send-email-bobby.prani@gmail.com> In-Reply-To: <1433946024-18439-1-git-send-email-bobby.prani@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH] qemu-log: Open file for logging when specified List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pranith Kumar , qemu-devel@nongnu.org Cc: Peter Maydell , Markus Armbruster , Luiz Capitulino On 10/06/2015 16:20, Pranith Kumar wrote: > qemu-log defaults to stderr when there is no '-D' option mentioned on command > line. When '-D' option is specified, we also need to specify '-d' option for it > to use the specified logfile. When using monitor to enable logging this is > troublesome since there will be no '-d' option because of which monitor dumps > the logs to stderr. > > Fix this by opening the log file when '-D' is specified on the command line. > Also fix an ancient comment which does not hold true since changing location and > log level has now been streamlined. > > Signed-off-by: Pranith Kumar > CC: Paolo Bonzini > CC: Luiz Capitulino > CC: Markus Armbruster > CC: Peter Maydell > --- > vl.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/vl.c b/vl.c > index d4b2d03..5f81ccc 100644 > --- a/vl.c > +++ b/vl.c > @@ -3845,17 +3845,14 @@ int main(int argc, char **argv, char **envp) > exit(0); > } > > - /* Open the logfile at this point, if necessary. We can't open the logfile > - * when encountering either of the logging options (-d or -D) because the > - * other one may be encountered later on the command line, changing the > - * location or level of logging. > + /* Open the logfile at this point and set the log mask if necessary. > */ > + if (log_file) { > + qemu_set_log_filename(log_file); > + } > + > if (log_mask) { > int mask; > - if (log_file) { > - qemu_set_log_filename(log_file); > - } > - > mask = qemu_str_to_log_mask(log_mask); > if (!mask) { > qemu_print_log_usage(stdout); > Good idea---also it is consistent with what user-mode emulation already does. Paolo