Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]

On 06/17/2015 05:48 AM, Markus Armbruster wrote:
> "Kővágó Zoltán" <dirty.ice.hu@gmail.com> writes:
> 
>> 2015-06-17 09:46 keltezéssel, Markus Armbruster írta:
>>> Copying Eric for additional QAPI schema expertise.
>>>

>>>> +{ 'struct': 'Audiodev',
>>>> +  'data': {
>>>> +    '*id':           'str',
>>>> +    'in':            'AudiodevPerDirectionOptions',
>>>> +    'out':           'AudiodevPerDirectionOptions',
>>>> +    '*timer-period': 'int',
>>>> +    'opts':          'AudiodevBackendOptions' } }
>>>
>>> Have you considered making this a flat union, similar ro
>>> BlockdevOptions?
>>
>> Not really. If you qapi masters out there think it's better, then I
>> will convert it.
> 
> Related: discussion about flattening in review of PATCH 2.

Indeed - I think a flat union makes for nicer command line structure,
and fewer {} nesting in QMP structure.  I still need to spend time on
the overall thread, but wanted to chime in on this comment up front.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]