From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC v2 3/6] memory: support unmapping of MemoryRegion mapped into HVA parent
Date: Wed, 17 Jun 2015 18:15:14 +0200 [thread overview]
Message-ID: <55819D12.7060203@redhat.com> (raw)
In-Reply-To: <20150617170704-mutt-send-email-mst@redhat.com>
On 17/06/2015 17:10, Michael S. Tsirkin wrote:
> > Actually memory_region_add_subregion(cannot fail) will continue to casue problems
> > in case one of the listeners fails and has no way to propagate error up the stack.
> > It could be that vhost_set_memory() or kvm_set_memslots() aren't able to allocate
> > memory for replacement table in low memory conditions and without
> > way to report back QEMU is left with option to die.
>
> mmap reserving memory just adds it to a data structure somewhere
> within glibc, doesn't it? Looks like it's highly unlikely to fail,
> so maybe killing QEMU if it does isn't a big deal.
It's in the kernel, but yes, a MAP_NORESERVE mmap is highly unlikely to
fail.
Paolo
next prev parent reply other threads:[~2015-06-17 16:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 15:19 [Qemu-devel] [RFC v2 0/6] Fix QEMU crash during memory hotplug with vhost=on Igor Mammedov
2015-06-08 15:19 ` [Qemu-devel] [RFC v2 1/6] memory: get rid of memory_region_destructor_ram_from_ptr() Igor Mammedov
2015-06-08 15:23 ` Paolo Bonzini
2015-06-08 16:08 ` Igor Mammedov
2015-06-08 16:09 ` Paolo Bonzini
2015-06-08 16:26 ` Igor Mammedov
2015-06-08 15:19 ` [Qemu-devel] [RFC v2 2/6] memory: introduce MemoryRegion container with reserved HVA range Igor Mammedov
2015-06-08 15:19 ` [Qemu-devel] [RFC v2 3/6] memory: support unmapping of MemoryRegion mapped into HVA parent Igor Mammedov
2015-06-08 15:26 ` Paolo Bonzini
2015-06-08 15:32 ` Paolo Bonzini
2015-06-08 16:13 ` Igor Mammedov
2015-06-08 16:25 ` Michael S. Tsirkin
2015-06-08 17:06 ` Paolo Bonzini
2015-06-09 10:08 ` Igor Mammedov
2015-06-17 8:14 ` Paolo Bonzini
2015-06-17 15:04 ` Igor Mammedov
2015-06-17 15:10 ` Michael S. Tsirkin
2015-06-17 16:15 ` Paolo Bonzini [this message]
2015-06-17 16:30 ` Michael S. Tsirkin
2015-06-08 15:19 ` [Qemu-devel] [RFC v2 4/6] hostmem: return recreated MemoryRegion if current can't be reused Igor Mammedov
2015-06-08 15:30 ` Paolo Bonzini
2015-06-08 16:25 ` Igor Mammedov
2015-06-08 16:28 ` Paolo Bonzini
2015-06-08 15:19 ` [Qemu-devel] [RFC v2 5/6] pc: reserve hotpluggable memory range with memory_region_init_hva_range() Igor Mammedov
2015-06-08 15:19 ` [Qemu-devel] [RFC v2 6/6] pc: fix QEMU crashing when more than ~50 memory hotplugged Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55819D12.7060203@redhat.com \
--to=pbonzini@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).