From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5GJb-0005uA-8e for qemu-devel@nongnu.org; Wed, 17 Jun 2015 12:35:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5GJW-0006bG-AJ for qemu-devel@nongnu.org; Wed, 17 Jun 2015 12:35:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5GJW-0006ai-5M for qemu-devel@nongnu.org; Wed, 17 Jun 2015 12:35:46 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id AA793385A77 for ; Wed, 17 Jun 2015 16:35:45 +0000 (UTC) Message-ID: <5581A1DD.3030902@redhat.com> Date: Wed, 17 Jun 2015 18:35:41 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20150617121148-mutt-send-email-mst@redhat.com> <55815B06.5030508@redhat.com> <20150617133816-mutt-send-email-mst@redhat.com> <55815FA7.3070205@redhat.com> <20150617135340-mutt-send-email-mst@redhat.com> <55816039.3080103@redhat.com> <20150617135716-mutt-send-email-mst@redhat.com> <5581660E.2090807@redhat.com> <20150617164437-mutt-send-email-mst@redhat.com> <55819D53.2090508@redhat.com> <20150617183046-mutt-send-email-mst@redhat.com> In-Reply-To: <20150617183046-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Migration compatibility for serial List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: amit.shah@redhat.com, qemu-devel@nongnu.org, "Dr. David Alan Gilbert (git)" , quintela@redhat.com On 17/06/2015 18:34, Michael S. Tsirkin wrote: > > > > I just tried, set prog_if to different values, sure it failed. > > > > > > How so? It's just a byte in config space. > > Why does it fail? Because pci core migrates it and validates it > on both sides. I cannot find it, can you show me the validation code? > > > David's patches are also guest visible, are they not? > > > We are losing state guest can indirectly observe, right? > > > > One case only happens during migration, the other does not. > > > True - apparently the bug was only in the migration stream, > not the functionality? Yes. Paolo