From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Tlg-0000zH-BP for qemu-devel@nongnu.org; Thu, 18 Jun 2015 02:57:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5Tlc-00060q-Sc for qemu-devel@nongnu.org; Thu, 18 Jun 2015 02:57:44 -0400 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:37118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Tlc-00060e-Mg for qemu-devel@nongnu.org; Thu, 18 Jun 2015 02:57:40 -0400 Received: by wicgi11 with SMTP id gi11so3615884wic.0 for ; Wed, 17 Jun 2015 23:57:40 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <55826BE1.9090804@redhat.com> Date: Thu, 18 Jun 2015 08:57:37 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1434563686-16744-1-git-send-email-serge.fdrv@gmail.com> In-Reply-To: <1434563686-16744-1-git-send-email-serge.fdrv@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] cpu-exec: Do not invalidate original TB in cpu_exec_nocache() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Fedorov , qemu-devel@nongnu.org Cc: Pavel Dovgalyuk On 17/06/2015 19:54, Sergey Fedorov wrote: > > - /* tb_gen_code can flush our orig_tb, invalidate it now */ > - tb_phys_invalidate(orig_tb, -1); > - tb = tb_gen_code(cpu, pc, cs_base, flags, > + tb = tb_gen_code(cpu, orig_tb->pc, orig_tb->cs_base, orig_tb->flags, > max_cycles | CF_NOCACHE); > + tb->orig_tb = orig_tb; What happens here if tb_gen_code calls tb_flush? Paolo