From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5WEJ-0006Ua-9d for qemu-devel@nongnu.org; Thu, 18 Jun 2015 05:35:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5WEE-000621-WF for qemu-devel@nongnu.org; Thu, 18 Jun 2015 05:35:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5WEE-00061v-Od for qemu-devel@nongnu.org; Thu, 18 Jun 2015 05:35:22 -0400 Message-ID: <558290D6.3030003@redhat.com> Date: Thu, 18 Jun 2015 11:35:18 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20150617124158.3316.54954.stgit@PASHA-ISP> <20150617124205.3316.81361.stgit@PASHA-ISP> <55816DAE.8090701@redhat.com> <001401d0a9a8$a0ff9a50$e2fecef0$@Dovgaluk@ispras.ru> <55828F9A.60809@redhat.com> <001501d0a9a9$cd10ecb0$6732c610$@Dovgaluk@ispras.ru> In-Reply-To: <001501d0a9a9$cd10ecb0$6732c610$@Dovgaluk@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: rth7680@gmail.com, leon.alrae@imgtec.com, aurelien@aurel32.net On 18/06/2015 11:33, Pavel Dovgaluk wrote: > > > /* Temporary aliases until backends are converted. */ > > > #ifdef TARGET_WORDS_BIGENDIAN > > > # define helper_ret_ldsw_mmu helper_be_ldsw_mmu > > > # define helper_ret_lduw_mmu helper_be_lduw_mmu > > > # define helper_ret_ldsl_mmu helper_be_ldsl_mmu > > > # define helper_ret_ldul_mmu helper_be_ldul_mmu > > > # define helper_ret_ldq_mmu helper_be_ldq_mmu > > > # define helper_ret_stw_mmu helper_be_stw_mmu > > > # define helper_ret_stl_mmu helper_be_stl_mmu > > > # define helper_ret_stq_mmu helper_be_stq_mmu > > > #else > > > > Isn't this exactly the same as your helper_call_ldw_cmmu? > > Yes, but I can't compile it yet. I'm not sure what's the problem. Can you just move this part of tcg/tcg.h to another header file? Paolo