From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Subject: Re: [Qemu-devel] [PATCH] cpu-exec: Do not invalidate original TB in cpu_exec_nocache()
Date: Thu, 18 Jun 2015 13:09:09 +0300 [thread overview]
Message-ID: <558298C5.50501@gmail.com> (raw)
In-Reply-To: <55826BE1.9090804@redhat.com>
On 18.06.2015 09:57, Paolo Bonzini wrote:
> On 17/06/2015 19:54, Sergey Fedorov wrote:
>>
>> - /* tb_gen_code can flush our orig_tb, invalidate it now */
>> - tb_phys_invalidate(orig_tb, -1);
>> - tb = tb_gen_code(cpu, pc, cs_base, flags,
>> + tb = tb_gen_code(cpu, orig_tb->pc, orig_tb->cs_base, orig_tb->flags,
>> max_cycles | CF_NOCACHE);
>> + tb->orig_tb = orig_tb;
> What happens here if tb_gen_code calls tb_flush?
>
> Paolo
I think I understand. Did you mean tcg_ctx.tb_ctx.tb_invalidated_flag
should be checked here?
Sergey
prev parent reply other threads:[~2015-06-18 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 17:54 [Qemu-devel] [PATCH] cpu-exec: Do not invalidate original TB in cpu_exec_nocache() Sergey Fedorov
2015-06-18 6:57 ` Paolo Bonzini
2015-06-18 10:09 ` Sergey Fedorov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558298C5.50501@gmail.com \
--to=serge.fdrv@gmail.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).