From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Ynq-0006VC-R8 for qemu-devel@nongnu.org; Thu, 18 Jun 2015 08:20:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5Ynk-0005Gs-Na for qemu-devel@nongnu.org; Thu, 18 Jun 2015 08:20:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Ynk-0005GN-Iv for qemu-devel@nongnu.org; Thu, 18 Jun 2015 08:20:12 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 251E3374A31 for ; Thu, 18 Jun 2015 12:20:12 +0000 (UTC) Message-ID: <5582B75A.3010402@redhat.com> Date: Thu, 18 Jun 2015 06:19:38 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434505833-11234-1-git-send-email-quintela@redhat.com> <1434505833-11234-12-git-send-email-quintela@redhat.com> <20150618105312.GH2248@work-vm> In-Reply-To: <20150618105312.GH2248@work-vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="psL5c49xibS396giU8Pvw4wxKg697SGoN" Subject: Re: [Qemu-devel] [PATCH 11/11] migration: Add migration events on target side List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , Juan Quintela Cc: amit.shah@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --psL5c49xibS396giU8Pvw4wxKg697SGoN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/18/2015 04:53 AM, Dr. David Alan Gilbert wrote: > * Juan Quintela (quintela@redhat.com) wrote: >> We reuse the migration events from the source side, sending them on th= e >> appropiate place. s/appropiate/appropriate/ >> >> Signed-off-by: Juan Quintela >> Reviewed-by: Eric Blake >> --- >> migration/migration.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/migration/migration.c b/migration/migration.c >> index 3637d36..2b4fd55 100644 >> --- a/migration/migration.c >> +++ b/migration/migration.c >> @@ -218,6 +218,7 @@ void qemu_start_incoming_migration(const char *uri= , Error **errp) >> { >> const char *p; >> >> + qapi_event_send_migration(MIGRATION_STATUS_SETUP, &error_abort); >=20 > Try and avoid error_abort - you don't want to trigger an assert (and as= sociated > core etc) if it's just something like the monitor disconnecting. > (And anyway in this case you have an errp). But this use is fine, matching the idiom of ALL OTHER qapi_event_send_* calls. (Arguably, if sending an event can never fail, then maybe we shouldn't have made it a parameter; OOM failures already abort, and if the only other possible failure is malformed json but the whole point of a generated code guarantees that we cannot hit that bug, or if the only failure is a disconnected monitor but you can't report the error because you have no monitor left, then being able to catch an error doesn't help)= =2E --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --psL5c49xibS396giU8Pvw4wxKg697SGoN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVgrdpAAoJEKeha0olJ0NqOSwIAII3Vf/MfNJSVR4au3tIgzR6 Tll1Tl1VZVJiAoofvHjrllP5TRkGlNwRyWc2HpekSZZhw1M0JbJzk0DQ3RNdhPMo 4kVIV0Z0Zm9NsddDaJowmeaNFBf9oV88Tr/mlULrgkXQoQUzbPI1wNriyJXk+lZe KabHqYxBm/1jVF4JZnen5uUENDxxALrWtYDFRR/N4eoKCDhVUT+jcwLh0jw8VYro o4CER3QKLyNNSBzE0TGf+mYgnbF+Jvw7Or2DI8q7/Y2zFCQjAXVR/T0Bl2SfabIQ xoZEMujUzIPysIDh3k2EsonydqJUwyjgHAP1vS8Dr+7KNHbGLJ0RDYf+LEmwKLU= =mqb/ -----END PGP SIGNATURE----- --psL5c49xibS396giU8Pvw4wxKg697SGoN--