From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-arm: Do not reset sysregs marked as ALIAS
Date: Fri, 19 Jun 2015 00:03:42 +0300 [thread overview]
Message-ID: <5583322E.8050802@gmail.com> (raw)
In-Reply-To: <CAFEAcA9POtgLVSJZmETB2osS_cUhW9=6pnz7w3GXd5QYwQfEhg@mail.gmail.com>
On 19.06.2015 00:01, Peter Maydell wrote:
> On 18 June 2015 at 21:57, Sergey Fedorov <serge.fdrv@gmail.com> wrote:
>> On 18.06.2015 23:46, Peter Maydell wrote:
>>> On 17 June 2015 at 16:25, Sergey Fedorov <serge.fdrv@gmail.com> wrote:
>>>> cp_reg_reset() is called from g_hash_table_foreach() which does not
>>>> define a specific ordering of the hash table iteration. Thus doing reset
>>>> for registers marked as ALIAS would give an ambiguous result when
>>>> resetvalue is different for original and alias resisters.
>>> Was this actually the case for any of our registers? ie, is this
>>> patch fixing a bug, or just cleaning up a potential cause of
>>> confusion?
>> Peter, I discovered such a confusing behavior for PMCR register and
>> decided to sort this out.
> Ah yes, nice catch. I'll fix up the commit message.
>
> -- PMM
Thanks!
prev parent reply other threads:[~2015-06-18 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 15:25 [Qemu-devel] [PATCH] target-arm: Do not reset sysregs marked as ALIAS Sergey Fedorov
2015-06-18 20:46 ` Peter Maydell
2015-06-18 20:57 ` Sergey Fedorov
2015-06-18 21:01 ` Peter Maydell
2015-06-18 21:03 ` Sergey Fedorov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5583322E.8050802@gmail.com \
--to=serge.fdrv@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).