[Qemu-devel] m68k orphaned?

[Qemu-devel] m68k orphaned?

[Greg Ungerer]

Hi All,

I see in the MAINTAINERS file that pretty much everything related
to the m68k architecture is listed as "Orphan".

I have some patches that have been around for quite a while (posted
here twice) to fix some issues with the ColdFire support.
[See https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg03224.html]

They are still relevant, still apply, and are still needed.
Does anyone have any suggestions how I can get them pushed into
mainline qemu?

Regards
Greg

Re: [Qemu-devel] m68k orphaned?

[Peter Crosthwaite]

On Thu, Jun 18, 2015 at 10:00 PM, Greg Ungerer <gerg@uclinux.org> wrote:
> Hi All,
>
> I see in the MAINTAINERS file that pretty much everything related
> to the m68k architecture is listed as "Orphan".
>
> I have some patches that have been around for quite a while (posted
> here twice) to fix some issues with the ColdFire support.
> [See https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg03224.html]
>

I found a 3 patch series and did a review. I see RTH put and RB to
patch 2 so I skipped over that.

> They are still relevant, still apply, and are still needed.
> Does anyone have any suggestions how I can get them pushed into
> mainline qemu?
>

It suggests that you are the closest thing we have to a maintainer.
You could try sending a PULL as there is  no submaintainer that is
going to actively pick this up. The other alternative is the trivial
patches queue, although they are a little non-trivial due to
functional change.

Regards,
Peter

> Regards
> Greg
>
>

Re: [Qemu-devel] m68k orphaned?

[Greg Ungerer]

Hi Peter,

On 19/06/15 15:53, Peter Crosthwaite wrote:
> On Thu, Jun 18, 2015 at 10:00 PM, Greg Ungerer <gerg@uclinux.org> wrote:
>> Hi All,
>>
>> I see in the MAINTAINERS file that pretty much everything related
>> to the m68k architecture is listed as "Orphan".
>>
>> I have some patches that have been around for quite a while (posted
>> here twice) to fix some issues with the ColdFire support.
>> [See https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg03224.html]
>>
> 
> I found a 3 patch series and did a review. I see RTH put and RB to
> patch 2 so I skipped over that.
> 
>> They are still relevant, still apply, and are still needed.
>> Does anyone have any suggestions how I can get them pushed into
>> mainline qemu?
>>
> 
> It suggests that you are the closest thing we have to a maintainer.
> You could try sending a PULL as there is  no submaintainer that is
> going to actively pick this up. The other alternative is the trivial
> patches queue, although they are a little non-trivial due to
> functional change.

Thanks for the advice. Do I send the request to Peter Maydell?

I don't currently have a public git tree for this, can I just
send the patches?  I can always set up a git hub tree if that
is a must.

Regards
Greg

Re: [Qemu-devel] m68k orphaned?

[Peter Maydell]

On 19 June 2015 at 06:00, Greg Ungerer <gerg@uclinux.org> wrote:
> Hi All,
>
> I see in the MAINTAINERS file that pretty much everything related
> to the m68k architecture is listed as "Orphan".
>
> I have some patches that have been around for quite a while (posted
> here twice) to fix some issues with the ColdFire support.
> [See https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg03224.html]
>
> They are still relevant, still apply, and are still needed.
> Does anyone have any suggestions how I can get them pushed into
> mainline qemu?

If you make the minor fixes Peter C has suggested, rebase
them onto current master and resend with the relevant
reviewed-by: tags in the commit messages, I'll apply
them to master.

If you're interested in taking on maintenance of m68k
longer-term we can discuss that, but right now let's
just get the fixes in.

thanks
-- PMM

Re: [Qemu-devel] m68k orphaned?

[Greg Ungerer]

Hi Peter,

On 19/06/15 17:12, Peter Maydell wrote:
> On 19 June 2015 at 06:00, Greg Ungerer <gerg@uclinux.org> wrote:
>> Hi All,
>>
>> I see in the MAINTAINERS file that pretty much everything related
>> to the m68k architecture is listed as "Orphan".
>>
>> I have some patches that have been around for quite a while (posted
>> here twice) to fix some issues with the ColdFire support.
>> [See https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg03224.html]
>>
>> They are still relevant, still apply, and are still needed.
>> Does anyone have any suggestions how I can get them pushed into
>> mainline qemu?
> 
> If you make the minor fixes Peter C has suggested, rebase
> them onto current master and resend with the relevant
> reviewed-by: tags in the commit messages, I'll apply
> them to master.

Thats great, thanks. I'll update them and get them to you.


> If you're interested in taking on maintenance of m68k
> longer-term we can discuss that, but right now let's
> just get the fixes in.

Sounds good, thanks.

Regards
Greg

Re: [Qemu-devel] m68k orphaned?

[Peter Maydell]

On 19 June 2015 at 08:17, Greg Ungerer <gerg@uclinux.org> wrote:
> Hi Peter,
>
> On 19/06/15 17:12, Peter Maydell wrote:
>> If you make the minor fixes Peter C has suggested, rebase
>> them onto current master and resend with the relevant
>> reviewed-by: tags in the commit messages, I'll apply
>> them to master.
>
> Thats great, thanks. I'll update them and get them to you.

I mean "send to the list and cc me", just to be clear.

-- PMM