From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52835)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z5r8n-0005rq-Ja
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 03:55:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z5r8m-0008R3-Nl
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 03:55:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34166)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z5r8m-0008QY-BJ
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 03:55:08 -0400
Message-ID: <5583CAD7.8010503@redhat.com>
Date: Fri, 19 Jun 2015 09:55:03 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1434698944-3331-1-git-send-email-pbonzini@redhat.com>
	<20150619095359.1bda48e4@thh440s>
In-Reply-To: <20150619095359.1bda48e4@thh440s>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed
 declaration rules
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>, Andreas Faerber <afaerber@suse.de>



On 19/06/2015 09:53, Thomas Huth wrote:
> > -			WARN("line over 80 characters\n" . $herecurr);
> > +			if ($length > 90) {
> > +				ERROR("line over 90 characters\n" . $herecurr);
> > +			} if ($length > 80) {
> 
> Did you mean to use "elsif" here instead (because you've put the if on
> the same line as the "}")?

Yes, and this patch was really meant as little more than RFC.

Paolo