From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5rv9-0007i6-9k for qemu-devel@nongnu.org; Fri, 19 Jun 2015 04:45:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5rv4-0003sA-Vv for qemu-devel@nongnu.org; Fri, 19 Jun 2015 04:45:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55291 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5rv4-0003qg-Pu for qemu-devel@nongnu.org; Fri, 19 Jun 2015 04:45:02 -0400 Message-ID: <5583D68D.8000506@suse.de> Date: Fri, 19 Jun 2015 10:45:01 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1432750824-27702-1-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL v2 00/12] QOM devices patch queue 2015-05-27 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , QEMU Developers , Eduardo Habkost Am 28.05.2015 um 13:46 schrieb Peter Maydell: > On 27 May 2015 at 19:20, Andreas F=C3=A4rber wrote: >> Hello Peter, >> >> This is my QOM (devices) patch queue. Please pull. >> >> v2 contains changes that hopefully fix warnings on gcc 4.7. >=20 > Hi. I'm afraid this doesn't build on our minimum glib version (2.22): >=20 > /Users/pm215/src/qemu/tests/check-qom-proplist.c:235:5: warning: implic= it > declaration of function 'g_assert_null' is invalid in C99 > [-Wimplicit-function-declaration] > g_assert_null(dobj); > ^ > /Users/pm215/src/qemu/tests/check-qom-proplist.c:236:5: warning: implic= it > declaration of function 'g_assert_nonnull' is invalid in C99 > [-Wimplicit-function-declaration] > g_assert_nonnull(err); > ^ >=20 > g_assert_nonnull() first appears in glib 2.38. Holy crap... :/ I could've sworn that Anthony did not apply the same minimum-glib version for make check as for the actual code, and macros should be easy to add to our glib-compat.h, but let's get this in first and consider refactorings then. Unfortunately the pull no longer applies cleanly due to QemuOpts changes in vl.c, looking into it. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)