From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5tAa-0000VL-7Y for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:05:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5tAV-0000h0-Im for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:05:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5tAV-0000g3-DK for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:05:03 -0400 Message-ID: <5583E943.4000802@redhat.com> Date: Fri, 19 Jun 2015 12:04:51 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1432750824-27702-1-git-send-email-afaerber@suse.de> <1432750824-27702-8-git-send-email-afaerber@suse.de> <5583E8E1.7090604@suse.de> In-Reply-To: <5583E8E1.7090604@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL v2 07/12] vl: Create (most) objects before creating chardev backends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: Markus Armbruster On 19/06/2015 12:03, Andreas F=C3=A4rber wrote: > Am 27.05.2015 um 20:20 schrieb Andreas F=C3=A4rber: >> From: "Daniel P. Berrange" >> >> Some types of object must be created before chardevs, other types of >> object must be created after chardevs. As such there is no option but >> to create objects in two phases. >> >> This takes the decision to create as many object types as possible >> right away before anyother backends are created, and only delay >> creation of those few which have an explicit dependency on the >> chardevs. Hopefully the set which need delaying will remain small >> over time. >> >> Signed-off-by: Daniel P. Berrange >> Reviewed-by: Paolo Bonzini >> Signed-off-by: Andreas F=C3=A4rber >> --- >> vl.c | 40 +++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 39 insertions(+), 1 deletion(-) >=20 > Rebasing my queue, I needed the attached changes to make it apply and > build. Second pairs of eyes welcome. Looks good. Paolo