From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5vix-0005IV-55 for qemu-devel@nongnu.org; Fri, 19 Jun 2015 08:48:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5vis-000129-Tj for qemu-devel@nongnu.org; Fri, 19 Jun 2015 08:48:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5vis-0000zg-NP for qemu-devel@nongnu.org; Fri, 19 Jun 2015 08:48:42 -0400 Message-ID: <55840FA4.5030608@redhat.com> Date: Fri, 19 Jun 2015 06:48:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434706529-13895-1-git-send-email-w.bumiller@proxmox.com> <1434706529-13895-2-git-send-email-w.bumiller@proxmox.com> In-Reply-To: <1434706529-13895-2-git-send-email-w.bumiller@proxmox.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E6fAcM2qQoLWVshr39KtFgmePeONH78AF" Subject: Re: [Qemu-devel] [PATCH v2 1/1] vvfat: add a label option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wolfgang Bumiller , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E6fAcM2qQoLWVshr39KtFgmePeONH78AF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/19/2015 03:35 AM, Wolfgang Bumiller wrote: > Until now the vvfat volume label was hardcoded to be > "QEMU VVFAT", now you can pass a file.label=3Dlabelname option > to the -drive to change it. >=20 > The FAT structure defines the volume label to be limited to > 11 bytes and is filled up spaces when shorter than that. The > trailing spaces however aren't exposed to the user by > operating systems. >=20 > Signed-off-by: Wolfgang Bumiller > --- > block/vvfat.c | 25 ++++++++++++++++++++++--- > qapi/block-core.json | 6 +++++- > 2 files changed, 27 insertions(+), 4 deletions(-) >=20 > +++ b/qapi/block-core.json > @@ -1453,13 +1453,17 @@ > # @fat-type: #optional FAT type: 12, 16 or 32 > # @floppy: #optional whether to export a floppy image (true) or > # partitioned hard disk (false; default) > +# @label: #optional set the volume label, limited to 11 bytes. F= AT16 and > + FAT32 traditionally have some restrictions on labels, = which are > + ignored by most operating systems. Defaults to "QEMU V= VFAT". > + (since 2.4) Nicer; thanks. (Still doesn't mention what those restrictions are, but I'm not as worried about that) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --E6fAcM2qQoLWVshr39KtFgmePeONH78AF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVhA+kAAoJEKeha0olJ0NqV/UIAJt2N+EB0q/9zIsb4CsUoDFL OoGdg4ua2y3+cNn5QNIcLF/RQcPjQvINuCJM8fDI4FMp7zvOj33g7rKwwDTzTB3z 7gahE0jmTwnZXun7ggXiZ+WtVKOHJmO4aBtIX0VV8iG9peCc457nHks5NapLR+SZ FqP9ZfY1WOL0PXDXhB6iof9Ii6H/kpmMFZPX1f/4OVbaBIMOviFNcozW+WBwis9r B+2vEirjyj8YAaN2ochYM+CemFSNskQ7QjxrtbJ4UY6G91fGjWlgNY2LpnxvNjZj 1BuGy61H367WfTVu6tz/eQQuDFFONpjBGEFzG/D7KfTp5FwiTHLJ9EZEGtu0+FE= =wn/6 -----END PGP SIGNATURE----- --E6fAcM2qQoLWVshr39KtFgmePeONH78AF--