From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5y14-0005H5-CF for qemu-devel@nongnu.org; Fri, 19 Jun 2015 11:15:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5y0z-0005Sz-Cl for qemu-devel@nongnu.org; Fri, 19 Jun 2015 11:15:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52282 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5y0z-0005SW-66 for qemu-devel@nongnu.org; Fri, 19 Jun 2015 11:15:33 -0400 Message-ID: <55843214.8070708@suse.de> Date: Fri, 19 Jun 2015 17:15:32 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1432739276-10452-1-git-send-email-berrange@redhat.com> <1432739276-10452-9-git-send-email-berrange@redhat.com> In-Reply-To: <1432739276-10452-9-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 8/8] qom: don't pass string table to object_get_enum method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Paolo Bonzini Am 27.05.2015 um 17:07 schrieb Daniel P. Berrange: > Now that properties can be explicitly registered as an enum > type, there is no need to pass the string table to the > object_get_enum method. The object property registration > already has a pointer to the string table. >=20 > In changing this method signature, the hostmem backend object > has to be converted to use the new enum property registration > code, which simplifies it somewhat. >=20 > Signed-off-by: Daniel P. Berrange > --- > backends/hostmem.c | 22 ++++++++-------------- > include/qom/object.h | 4 ++-- > numa.c | 2 +- > qom/object.c | 19 +++++++++++++++++-- > tests/check-qom-proplist.c | 43 ++++++++++++++++++++++++++++++++++++++= +++++ > 5 files changed, 71 insertions(+), 19 deletions(-) There's been no protest after it appeared in v4, so I'm applying it for my v3 pull. If anyone has objections, please speak up now. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)