From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5ynU-0000qh-DG for qemu-devel@nongnu.org; Fri, 19 Jun 2015 12:05:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5ynP-0007Jv-Tz for qemu-devel@nongnu.org; Fri, 19 Jun 2015 12:05:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5ynP-0007Jl-Nu for qemu-devel@nongnu.org; Fri, 19 Jun 2015 12:05:35 -0400 Message-ID: <55843DCE.1000502@redhat.com> Date: Fri, 19 Jun 2015 10:05:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432739276-10452-1-git-send-email-berrange@redhat.com> <1432739276-10452-7-git-send-email-berrange@redhat.com> In-Reply-To: <1432739276-10452-7-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NwkBs2h712mw89mNWVKanbV412T0FoiTw" Subject: Re: [Qemu-devel] [PATCH v5 6/8] qom: make enum string tables const-correct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NwkBs2h712mw89mNWVKanbV412T0FoiTw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/27/2015 09:07 AM, Daniel P. Berrange wrote: > The enum string table parameters in various QOM/QAPI methods > are declared 'const char *strings[]'. This results in const > warnings if passed a variable that was declared as >=20 > static const char * const strings[] =3D { .... }; Not sure if the style would be '*const' instead of '* const' everywhere, but if checkpatch.pl didn't complain, it's not worth a respin. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NwkBs2h712mw89mNWVKanbV412T0FoiTw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVhD3OAAoJEKeha0olJ0Nqw2EH+wTZJ14ViC1H/cxXFOD43Kk+ XIMCqqx8PuCrK2sRQEwiQrhLsHnZJmuejUCc/OKbAFK9qR7hpGsbPGhLm9hn8jg6 p+SzyQWGBB88qT7A8lPKcaWKhods+N3RhxBCsfXnUXB9MY+p8PvyVTnCF04OvR0A 7Oz/ZJK0Ae2TGJFZ66cKMWcdNWq+LIPSyY9woEizoJ9bRrrzcyAWStGQ/ZrUbAnW Tf6HHYYEyLfPzoIMFW411QOecXhH495sXWlLD8nJrDZH/zxZ0ny8btLakf5RPg8x VY7gQqTvnjHoFBR+91xexfs3xVZobc/SSLZnDMF77q43WJ+8pcNwaz2uoH7W5dU= =k6N7 -----END PGP SIGNATURE----- --NwkBs2h712mw89mNWVKanbV412T0FoiTw--