From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5yqf-0003OD-7D for qemu-devel@nongnu.org; Fri, 19 Jun 2015 12:08:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5yqb-0000ni-W7 for qemu-devel@nongnu.org; Fri, 19 Jun 2015 12:08:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54997 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5yqb-0000mh-MJ for qemu-devel@nongnu.org; Fri, 19 Jun 2015 12:08:53 -0400 Message-ID: <55843E90.6090708@suse.de> Date: Fri, 19 Jun 2015 18:08:48 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1432739276-10452-1-git-send-email-berrange@redhat.com> <1432739276-10452-6-git-send-email-berrange@redhat.com> <55843D7E.3080300@redhat.com> In-Reply-To: <55843D7E.3080300@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2CBq3efPeq1kMiAKUbnwt3s7Fphrkgvwe" Subject: Re: [Qemu-devel] [PATCH v5 5/8] qom: add object_new_with_props / object_new_withpropv constructors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2CBq3efPeq1kMiAKUbnwt3s7Fphrkgvwe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 19.06.2015 um 18:04 schrieb Eric Blake: > On 05/27/2015 09:07 AM, Daniel P. Berrange wrote: >> It is reasonably common to want to create an object, set a >> number of properties, register it in the hierarchy and then >> mark it as complete (if a user creatable type). This requires >> quite a lot of error prone, verbose, boilerplate code to achieve. >> >=20 >> /** >> + * object_new_with_props: >> + * @typename: The name of the type of the object to instantiate. >> + * @parent: the parent object >> + * @id: The unique ID of the object >> + * @errp: pointer to error object >> + * @...: list of property names and values >> + * >> + * This function will initialize a new object using heap allocated me= mory. >> + * The returned object has a reference count of 1, and will be freed = when >> + * the last reference is dropped. >> + * >> + * The @id parameter will be used when registering the object as a >> + * child of @parent in the objects composition tree. >=20 > s/objects/object's/ Actually I think /objects is meant, so looks okay to me? Please do check the version in my tree or in the two PULLs though, as I edited most messages, including capitalization in subject, use of () for functions and s/method/function/g. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg) --2CBq3efPeq1kMiAKUbnwt3s7Fphrkgvwe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVhD6UAAoJEPou0S0+fgE/0F4QAJ8yYh6KX7+0orlrJL+6tPOZ myj38rhSOAiH6EWrj916viiUi4TyE4L+cEoU5SbVtf/lBkOKSPIils4eu7yJxzbL 2FrRisZ7daQ5e5yKc6ozqYmYEYXp2gsQgax0HruPrWs68zWdcx4BhKxgSNqMkp6D bGrRNUbyMucL75Gh7KfAs2gmEBxFb6KDuhIfBGKoClPOw49are1P0G8wDwMKIUIO LEziDyR6+ZmANMpZ2ftdcKz3DkZV65o2AYb8KO3/wqMyMdOFSNBr126ImJs5/HmL wuZ7ZX8zXN1xuGqk1CYDQd7Gy0XvoIDTDfEteecdUggH8iyYu69FW8Fx7NbOf/zt +pG71VZJB/jCDYz/m/gMf3bOuTLNkiPfZ8LwcfHcmNXxCWCRL6DOaKg7GZdUn7kQ NcXzoOEZRdouy/WXXkCDdwd54bpVULgyKJg3uINvRii8gtnS5y44dcdM8q+VO9dz 5bzLnC0OGszJxNOA5dgaHaX5O1611q63jkAyoWBOrOGD/ESRpBB36jjlEkNJqgZj Kp7X9w2aYXOUz9CWp3e0zmQ5yr7X63HgNaupag2bz8qQgOcdw33Q2WGluvBOnhny Cym8FEucB9i0ceZm18/K6/tBnJI/NkiRqkSCRU68Nx/3bFJeeS8FTvEbMe3g2x3a vZFSGjDGiKB7xgwPTMMR =NVah -----END PGP SIGNATURE----- --2CBq3efPeq1kMiAKUbnwt3s7Fphrkgvwe--