From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5yx5-0006GB-O2 for qemu-devel@nongnu.org; Fri, 19 Jun 2015 12:15:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5yx2-0004ie-IF for qemu-devel@nongnu.org; Fri, 19 Jun 2015 12:15:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5yx2-0004hD-CL for qemu-devel@nongnu.org; Fri, 19 Jun 2015 12:15:32 -0400 Message-ID: <55844022.20207@redhat.com> Date: Fri, 19 Jun 2015 10:15:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432739276-10452-1-git-send-email-berrange@redhat.com> <1432739276-10452-9-git-send-email-berrange@redhat.com> <55843214.8070708@suse.de> In-Reply-To: <55843214.8070708@suse.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TNI1iIc0kB5h99Na9DINmB8Pdbt1BPpXB" Subject: Re: [Qemu-devel] [PATCH v5 8/8] qom: don't pass string table to object_get_enum method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TNI1iIc0kB5h99Na9DINmB8Pdbt1BPpXB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/19/2015 09:15 AM, Andreas F=C3=A4rber wrote: > Am 27.05.2015 um 17:07 schrieb Daniel P. Berrange: >> Now that properties can be explicitly registered as an enum >> type, there is no need to pass the string table to the >> object_get_enum method. The object property registration >> already has a pointer to the string table. >> >> In changing this method signature, the hostmem backend object >> has to be converted to use the new enum property registration >> code, which simplifies it somewhat. >> >> Signed-off-by: Daniel P. Berrange >> --- >> backends/hostmem.c | 22 ++++++++-------------- >> include/qom/object.h | 4 ++-- >> numa.c | 2 +- >> qom/object.c | 19 +++++++++++++++++-- >> tests/check-qom-proplist.c | 43 +++++++++++++++++++++++++++++++++++++= ++++++ >> 5 files changed, 71 insertions(+), 19 deletions(-) >=20 > There's been no protest after it appeared in v4, so I'm applying it for= > my v3 pull. If anyone has objections, please speak up now. I pointed out a couple of minor issues, but they are not showstoppers, so you can add to the series: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --TNI1iIc0kB5h99Na9DINmB8Pdbt1BPpXB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVhEAiAAoJEKeha0olJ0NqGHoH/ibzqTt+JQVTPFEwjFmwJi2F +B9dLdZ7VtKqDWbpwt6+bpieeY84cUEAinBNFfg13zb7ORV3hFQvqPvXd6vpn80o naveyQZGfw8rS7ykDOGEc5fo9t8QA8dTDe3t4E5j8CtBb9Wn9bn2nT78uPQ5hK3O cQFL2VE0i4AovYX3z4P8qZl0paijLsucd9ZvFnnI85OhB3KhNTFdd2oyNeIsVzl4 Rclu4KLnvs+7dEFwhzLuR67M1CxsekpDI9i8QOWW2yB95u8QNA63io9BhLjbTZfz 8qOCF5kAH3BXUcj7r+ixbh792VXeYgtxFHIW1rYg58m4m6hcHbmJGdXGlnZ/oLU= =KcRB -----END PGP SIGNATURE----- --TNI1iIc0kB5h99Na9DINmB8Pdbt1BPpXB--