From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5yyc-0007LI-93 for qemu-devel@nongnu.org; Fri, 19 Jun 2015 12:17:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5yyZ-0005un-3l for qemu-devel@nongnu.org; Fri, 19 Jun 2015 12:17:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5yyY-0005uc-Rm for qemu-devel@nongnu.org; Fri, 19 Jun 2015 12:17:07 -0400 Message-ID: <55844081.10208@redhat.com> Date: Fri, 19 Jun 2015 10:17:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432739276-10452-1-git-send-email-berrange@redhat.com> <1432739276-10452-6-git-send-email-berrange@redhat.com> <55843D7E.3080300@redhat.com> <55843E90.6090708@suse.de> In-Reply-To: <55843E90.6090708@suse.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nWOq3xotLHoNnhscXP3Pkf4QJMiNwFjj2" Subject: Re: [Qemu-devel] [PATCH v5 5/8] qom: add object_new_with_props / object_new_withpropv constructors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nWOq3xotLHoNnhscXP3Pkf4QJMiNwFjj2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/19/2015 10:08 AM, Andreas F=C3=A4rber wrote: > Am 19.06.2015 um 18:04 schrieb Eric Blake: >> On 05/27/2015 09:07 AM, Daniel P. Berrange wrote: >>> It is reasonably common to want to create an object, set a >>> number of properties, register it in the hierarchy and then >>> mark it as complete (if a user creatable type). This requires >>> quite a lot of error prone, verbose, boilerplate code to achieve. >>> >> >>> /** >>> + * object_new_with_props: >>> + * @typename: The name of the type of the object to instantiate. >>> + * @parent: the parent object >>> + * @id: The unique ID of the object >>> + * @errp: pointer to error object >>> + * @...: list of property names and values >>> + * >>> + * This function will initialize a new object using heap allocated m= emory. >>> + * The returned object has a reference count of 1, and will be freed= when >>> + * the last reference is dropped. >>> + * >>> + * The @id parameter will be used when registering the object as a >>> + * child of @parent in the objects composition tree. >> >> s/objects/object's/ >=20 > Actually I think /objects is meant, so looks okay to me? Then s,objects,/objects, :) Yes, that reads okay as well (and now you see why adding a character, whether / or ', makes a difference). >=20 > Please do check the version in my tree or in the two PULLs though, as I= > edited most messages, including capitalization in subject, use of () fo= r > functions and s/method/function/g. >=20 > Regards, > Andreas >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nWOq3xotLHoNnhscXP3Pkf4QJMiNwFjj2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVhECBAAoJEKeha0olJ0NqcxgH/j8GTvxYAOOTvf3m1e6NjdoB e8gs55XB/qk0zgocHgNXypEEpeqVGsdSBYOP/ApPmVkn7XA3e/dHeBmotVEBn+Eb GJheFypIny42AOYq3C4nN3m5w/DqokQkrN4SnSeF+fZRsX93MyYXpa3eRiG2mL8M BkC1wCW4xgt5wNK+I3lSWmeZ2TqBtJP2rKG7lI4A3k8id+jwxJT4wAKkGvOK93Yd 8TChmPxPIWuzGuR5sTHT1FivjDUDUgn6SpfQ4cSY4VsXFOYPWaQDNDAI6Q2HsvOe DHaywrwaNcE5oK67iS5eaivjsqYspO0uqnS6b6vkAvpzvxEROP7J4njCTXMaAm8= =vhzy -----END PGP SIGNATURE----- --nWOq3xotLHoNnhscXP3Pkf4QJMiNwFjj2--