From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5zp1-0004uf-UQ for qemu-devel@nongnu.org; Fri, 19 Jun 2015 13:11:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5zot-0000Xq-2M for qemu-devel@nongnu.org; Fri, 19 Jun 2015 13:11:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58182 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5zos-0000Xf-SV for qemu-devel@nongnu.org; Fri, 19 Jun 2015 13:11:11 -0400 Message-ID: <55844D2D.9040404@suse.de> Date: Fri, 19 Jun 2015 19:11:09 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1434723448-24879-1-git-send-email-armbru@redhat.com> In-Reply-To: <1434723448-24879-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 0/7] qdev: Mostly wean off QError List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, kraxel@redhat.com Am 19.06.2015 um 16:17 schrieb Markus Armbruster: > Only the calls in do_device_add() remain, because QMP's command > handler interface requires them. They'll go away when I wean QMP off > QError. >=20 > Bonus: a few error reporting improvements. >=20 > Casualty: some explanatory messages, see PATCH 5. >=20 > v3: > * Trivially rebased, R-bys retained > * PATCH 1: Add rationale to commit message [Andreas] > * PATCH 2: Don't drop the comment outright, update it [Andreas] > * PATCH 3: Comment and commit message typos [Andreas] > v2: > * Trivially rebased > * PATCH 5+7: Error and commit message polish [Eric] >=20 > Markus Armbruster (7): > qdev: Deprecated qdev_init() is finally unused, drop > qdev: Un-deprecate qdev_init_nofail() Thanks, I applied these two to qom-next: https://github.com/afaerber/qemu-cpu/commits/qom-next > qdev-monitor: Stop error avalanche in qbus_find_recursive() > qdev-monitor: Fix check for full bus > qdev-monitor: Convert qbus_find() to Error > qdev-monitor: Propagate errors through set_property() > qdev-monitor: Propagate errors through qdev_device_add() Only 7/7 touches qdev.h again and should apply independently, so should be fine to go through your monitor queue. Thanks, Andreas >=20 > hw/core/qdev.c | 47 ++++++--------- > include/hw/qdev-core.h | 5 +- > include/monitor/qdev.h | 2 +- > include/qapi/qmp/qerror.h | 3 - > qdev-monitor.c | 143 ++++++++++++++++++++++++++------------= -------- > vl.c | 7 ++- > 6 files changed, 106 insertions(+), 101 deletions(-) --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)