From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Scott Feldman <sfeldma@gmail.com>, Jiri Pirko <jiri@resnulli.us>,
David Ahern <dsahern@gmail.com>
Subject: Re: [Qemu-devel] [PULL 6/9] rocker: add new rocker switch device
Date: Sat, 20 Jun 2015 23:07:30 +0200 [thread overview]
Message-ID: <5585D612.3080504@redhat.com> (raw)
In-Reply-To: <1431357979-17662-7-git-send-email-stefanha@redhat.com>
On 11/05/2015 17:26, Stefan Hajnoczi wrote:
> + switch (tx_offload) {
> + case ROCKER_TX_OFFLOAD_L3_CSUM:
> + if (!tlvs[ROCKER_TLV_TX_L3_CSUM_OFF]) {
> + return -ROCKER_EINVAL;
> + }
Is the fallthrough intentional here?
Paolo
> + case ROCKER_TX_OFFLOAD_TSO:
> + if (!tlvs[ROCKER_TLV_TX_TSO_MSS] ||
> + !tlvs[ROCKER_TLV_TX_TSO_HDR_LEN]) {
> + return -ROCKER_EINVAL;
> + }
> + }
> +
next prev parent reply other threads:[~2015-06-20 21:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 15:26 [Qemu-devel] [PULL 0/9] Net patches Stefan Hajnoczi
2015-05-11 15:26 ` [Qemu-devel] [PULL 1/9] net: add MAC address string printer Stefan Hajnoczi
2015-05-11 15:26 ` [Qemu-devel] [PULL 2/9] virtio-net: use qemu_mac_strdup_printf Stefan Hajnoczi
2015-05-11 15:26 ` [Qemu-devel] [PULL 3/9] rocker: add register programming guide Stefan Hajnoczi
2015-05-11 15:26 ` [Qemu-devel] [PULL 4/9] pci: add rocker device ID Stefan Hajnoczi
2015-05-11 15:26 ` [Qemu-devel] [PULL 5/9] pci: add network device class 'other' for network switches Stefan Hajnoczi
2015-05-11 15:26 ` [Qemu-devel] [PULL 6/9] rocker: add new rocker switch device Stefan Hajnoczi
2015-06-20 21:07 ` Paolo Bonzini [this message]
2015-05-11 15:26 ` [Qemu-devel] [PULL 7/9] rocker: add tests Stefan Hajnoczi
2015-05-11 15:26 ` [Qemu-devel] [PULL 8/9] MAINTAINERS: add rocker Stefan Hajnoczi
2015-05-11 15:26 ` [Qemu-devel] [PULL 9/9] rocker: timestamp on the debug logs helps correlate with events in the VM Stefan Hajnoczi
2015-05-12 10:41 ` [Qemu-devel] [PULL 0/9] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5585D612.3080504@redhat.com \
--to=pbonzini@redhat.com \
--cc=dsahern@gmail.com \
--cc=jiri@resnulli.us \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sfeldma@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).