From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47833)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z6PzF-0003SE-J5
	for qemu-devel@nongnu.org; Sat, 20 Jun 2015 17:07:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z6PzC-0003IM-Cv
	for qemu-devel@nongnu.org; Sat, 20 Jun 2015 17:07:37 -0400
Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:37182)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z6PzC-0003ID-5m
	for qemu-devel@nongnu.org; Sat, 20 Jun 2015 17:07:34 -0400
Received: by wicgi11 with SMTP id gi11so44755763wic.0
	for <qemu-devel@nongnu.org>; Sat, 20 Jun 2015 14:07:33 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5585D612.3080504@redhat.com>
Date: Sat, 20 Jun 2015 23:07:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1431357979-17662-1-git-send-email-stefanha@redhat.com>
	<1431357979-17662-7-git-send-email-stefanha@redhat.com>
In-Reply-To: <1431357979-17662-7-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 6/9] rocker: add new rocker switch device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Scott Feldman <sfeldma@gmail.com>, Jiri Pirko <jiri@resnulli.us>, David Ahern <dsahern@gmail.com>



On 11/05/2015 17:26, Stefan Hajnoczi wrote:
> +    switch (tx_offload) {
> +    case ROCKER_TX_OFFLOAD_L3_CSUM:
> +        if (!tlvs[ROCKER_TLV_TX_L3_CSUM_OFF]) {
> +            return -ROCKER_EINVAL;
> +        }

Is the fallthrough intentional here?

Paolo


> +    case ROCKER_TX_OFFLOAD_TSO:
> +        if (!tlvs[ROCKER_TLV_TX_TSO_MSS] ||
> +            !tlvs[ROCKER_TLV_TX_TSO_HDR_LEN]) {
> +            return -ROCKER_EINVAL;
> +        }
> +    }
> +