From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48849)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z6Q5E-0007J4-8B
	for qemu-devel@nongnu.org; Sat, 20 Jun 2015 17:13:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z6Q59-0006Sc-5F
	for qemu-devel@nongnu.org; Sat, 20 Jun 2015 17:13:48 -0400
Received: from mail-wg0-x235.google.com ([2a00:1450:400c:c00::235]:32780)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z6Q58-0006S4-Tb
	for qemu-devel@nongnu.org; Sat, 20 Jun 2015 17:13:43 -0400
Received: by wgez8 with SMTP id z8so113488808wge.0
	for <qemu-devel@nongnu.org>; Sat, 20 Jun 2015 14:13:42 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5585D783.5050405@redhat.com>
Date: Sat, 20 Jun 2015 23:13:39 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1434113861-26495-1-git-send-email-stefanha@redhat.com>
	<1434113861-26495-17-git-send-email-stefanha@redhat.com>
In-Reply-To: <1434113861-26495-17-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 16/16] qmp/hmp: add rocker device support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Scott Feldman <sfeldma@gmail.com>, Jiri Pirko <jiri@resnulli.us>



On 12/06/2015 14:57, Stefan Hajnoczi wrote:
> +    RockerSwitch *rocker = g_malloc0(sizeof(*rocker));
> +    Rocker *r;
> +
> +    r = rocker_find(name);
> +    if (!r) {
> +        error_set(errp, ERROR_CLASS_GENERIC_ERROR,
> +                  "rocker %s not found", name);
> +        return NULL;

Memory leak, please initialize rocker after the "if".

Paolo

> +    }
> +
> +    rocker->name = g_strdup(r->name);