From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49192)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z6Q7a-0008QS-F5
	for qemu-devel@nongnu.org; Sat, 20 Jun 2015 17:16:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z6Q7T-0007tL-KR
	for qemu-devel@nongnu.org; Sat, 20 Jun 2015 17:16:14 -0400
Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:33488)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z6Q7T-0007t8-DR
	for qemu-devel@nongnu.org; Sat, 20 Jun 2015 17:16:07 -0400
Received: by wiwl6 with SMTP id l6so6361428wiw.0
	for <qemu-devel@nongnu.org>; Sat, 20 Jun 2015 14:16:06 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5585D813.8040007@redhat.com>
Date: Sat, 20 Jun 2015 23:16:03 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1431583614-20100-1-git-send-email-sfeldma@gmail.com>
	<1431583614-20100-5-git-send-email-sfeldma@gmail.com>
In-Reply-To: <1431583614-20100-5-git-send-email-sfeldma@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] qmp/hmp: add rocker device support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: sfeldma@gmail.com, qemu-devel@nongnu.org
Cc: jiri@resnulli.us, dsahern@gmail.com



On 14/05/2015 08:06, sfeldma@gmail.com wrote:
> +    case ROCKER_OF_DPA_GROUP_TYPE_L2_REWRITE:
> +        ngroup->has_index = true;
> +        ngroup->index = ROCKER_GROUP_INDEX_LONG_GET(group->id);
> +        ngroup->has_group_id = true;
> +        ngroup->group_id = group->l2_rewrite.group_id;
> +        if (group->l2_rewrite.vlan_id) {
> +            ngroup->has_set_vlan_id = true;
> +            ngroup->set_vlan_id = ntohs(group->l2_rewrite.vlan_id);
> +        }
> +        break;

Misplaced break?

Paolo

> +        if (memcmp(group->l2_rewrite.src_mac.a, zero_mac.a, ETH_ALEN)) {
> +            ngroup->has_set_eth_src = true;
> +            ngroup->set_eth_src =
> +                qemu_mac_strdup_printf(group->l2_rewrite.src_mac.a);
> +        }
> +        if (memcmp(group->l2_rewrite.dst_mac.a, zero_mac.a, ETH_ALEN)) {
> +            ngroup->has_set_eth_dst = true;
> +            ngroup->set_eth_dst =
> +                qemu_mac_strdup_printf(group->l2_rewrite.dst_mac.a);
> +        }
> +    case ROCKER_OF_DPA_GROUP_TYPE_L2_FLOOD: