From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Cc: Leonid Shatz <leonid.shatz@ravellosystems.com>,
Hannes Reinecke <hare@suse.de>,
Idan Brown <idan.brown@ravellosystems.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1] pci: Don't register a specialized 'config_write' if default behavior is intended
Date: Sun, 21 Jun 2015 11:16:50 +0300 [thread overview]
Message-ID: <558672F2.3040204@gmail.com> (raw)
In-Reply-To: <20150617214649.7740e8b9@pixies>
On 06/17/2015 09:46 PM, Shmulik Ladkani wrote:
> Hi,
>
> On Wed, 17 Jun 2015 12:36:14 +0300, marcel.apfelbaum@gmail.com wrote:
>>> NOTE:
>>> Not sure if my statement regarding ommitting 'config_write' holds
>>> for the megasas case:
>>> It's parent is TYPE_MEGASAS_BASE whose parent is TYPE_PCI_DEVICE.
>>> Can we assume 'config_write' will be set to
>>> 'pci_default_write_config' in this case?
>> No need to assume here, you can simply add a trace and check.
>> However, the do_pci_register_device method assigns config_write method
>> to PCIDevice *instances* using the class method or the default
>> pci_default_write_config.
>>
>> Since TYPE_MEGASAS_BASE does not define a config_write method, the
>> field will remain NULL. Anyway, you are welcomed to run it and
>> double-check.
>
> Verified; do_pci_register_device indeed sets it to pci_default_write_config.
>
> Thanks,
> Shmulik
>
Cool!
Thanks,
Marcel
prev parent reply other threads:[~2015-06-21 8:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 8:24 [Qemu-devel] [PATCH v1] pci: Don't register a specialized 'config_write' if default behavior is intended Shmulik Ladkani
2015-06-17 9:36 ` Marcel Apfelbaum
2015-06-17 9:37 ` Marcel Apfelbaum
2015-06-17 19:17 ` Shmulik Ladkani
2015-06-21 8:20 ` Marcel Apfelbaum
2015-06-21 8:28 ` Shmulik Ladkani
2015-06-17 18:46 ` Shmulik Ladkani
2015-06-21 8:16 ` Marcel Apfelbaum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558672F2.3040204@gmail.com \
--to=marcel.apfelbaum@gmail.com \
--cc=hare@suse.de \
--cc=idan.brown@ravellosystems.com \
--cc=leonid.shatz@ravellosystems.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shmulik.ladkani@ravellosystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).