From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6yQ0-0007Um-S4 for qemu-devel@nongnu.org; Mon, 22 Jun 2015 05:53:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6yPw-0001LY-9y for qemu-devel@nongnu.org; Mon, 22 Jun 2015 05:53:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6yPw-0001LG-3p for qemu-devel@nongnu.org; Mon, 22 Jun 2015 05:53:28 -0400 Message-ID: <5587DB14.1000207@redhat.com> Date: Mon, 22 Jun 2015 11:53:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1434470874-22573-1-git-send-email-eric.auger@linaro.org> <5587D4AC.1050203@linaro.org> <5587D8DE.3060208@redhat.com> <5587DA3B.60702@linaro.org> In-Reply-To: <5587DA3B.60702@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vl: move rom_load_all after machine init done List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger , eric.auger@st.com, qemu-devel@nongnu.org, peter.maydell@linaro.org, peter.crosthwaite@xilinx.com Cc: christoffer.dall@linaro.org, patches@linaro.org On 22/06/2015 11:49, Eric Auger wrote: >> > It seems safe because rom_load_all really doesn't load anything, it only >> > does an overlap check. Is this right? > it does the check + isrom field setting >> > >> > Is the bug that some overlapping ROMs are not detected? The commit >> > message is not clear. > The regression is that the both overlap check and isrom setting are not > done since ROM are inserted in the roms list afterwards, at machine init > done time. The bug was not really observed yet I think. isrom is just an optimization though, right? What is it useful for? Paolo