From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z71KR-00040B-JI for qemu-devel@nongnu.org; Mon, 22 Jun 2015 09:00:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z71KO-0005n7-DO for qemu-devel@nongnu.org; Mon, 22 Jun 2015 08:59:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z71KO-0005n1-7o for qemu-devel@nongnu.org; Mon, 22 Jun 2015 08:59:56 -0400 Message-ID: <558806C8.8050204@redhat.com> Date: Mon, 22 Jun 2015 14:59:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1432686576-14816-1-git-send-email-pcacjr@zytor.com> <1434933423-10496-1-git-send-email-pcacjr@zytor.com> <20150622104151-mutt-send-email-mst@redhat.com> <5587D93B.2060307@redhat.com> <20150622140648-mutt-send-email-mst@redhat.com> <02bf769ef17461985acbeef8f6d9bd82.squirrel@www.zytor.com> <20150622144216-mutt-send-email-mst@redhat.com> In-Reply-To: <20150622144216-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/3] ich9: add TCO interface emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Paulo Alcantara Cc: seabios@seabios.org, Paulo Alcantara , qemu-devel@nongnu.org On 22/06/2015 14:44, Michael S. Tsirkin wrote: > OK. Do you agree to move the ACPI bits to the SSDT, making > it conditional on device being enabled? Again, no. The chipset configuration registers range is always defined by the chipset, even if the TCO is not in use. It would have to be conditional on whether the RCBA is programmed by the firmware, not on whether the TCO watchdog is enabled. That's a very different patch, and it's independent of DSDT vs. SSDT. You have to draw a line between required work and nice-to-haves that the maintainer can do himself. Otherwise, the possibilities are: 1) the contributor is scared away, and we lose a valuable feature 2) the contributor does it, but then keeps all remaining contributions in house because the first one was such a hell to go through. Paolo