From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z74V7-0006Ib-Jo for qemu-devel@nongnu.org; Mon, 22 Jun 2015 12:23:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z74V4-0003lC-6Z for qemu-devel@nongnu.org; Mon, 22 Jun 2015 12:23:13 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:34299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z74V4-0003l1-06 for qemu-devel@nongnu.org; Mon, 22 Jun 2015 12:23:10 -0400 Received: by wicnd19 with SMTP id nd19so81713592wic.1 for ; Mon, 22 Jun 2015 09:23:09 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5588366B.4040401@redhat.com> Date: Mon, 22 Jun 2015 18:23:07 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <6fd2cd15902fabc2a76bab10789434aa94db0427.1434987161.git.atar4qemu@gmail.com> In-Reply-To: <6fd2cd15902fabc2a76bab10789434aa94db0427.1434987161.git.atar4qemu@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] cutils: fix compiling with icc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Artyom Tarasenko , qemu-devel@nongnu.org, Juan Quintela , Peter Lieven On 22/06/2015 18:11, Artyom Tarasenko wrote: > Intel C Compiler version 15.0.3.187 Build 20150407 doesn't support > '|' function for non floating-point simd operands. > Use instead _mm_or_si128 which is supported both in icc and gcc. This would work for x86, but not for Altivec or non-SIMD. Please define a new macro like VEC_OR instead. Paolo > Signed-off-by: Artyom Tarasenko > --- > util/cutils.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/util/cutils.c b/util/cutils.c > index 144b25c..ffc9ddb 100644 > --- a/util/cutils.c > +++ b/util/cutils.c > @@ -207,13 +207,13 @@ size_t buffer_find_nonzero_offset(const void *buf, size_t len) > for (i = BUFFER_FIND_NONZERO_OFFSET_UNROLL_FACTOR; > i < len / sizeof(VECTYPE); > i += BUFFER_FIND_NONZERO_OFFSET_UNROLL_FACTOR) { > - VECTYPE tmp0 = p[i + 0] | p[i + 1]; > - VECTYPE tmp1 = p[i + 2] | p[i + 3]; > - VECTYPE tmp2 = p[i + 4] | p[i + 5]; > - VECTYPE tmp3 = p[i + 6] | p[i + 7]; > - VECTYPE tmp01 = tmp0 | tmp1; > - VECTYPE tmp23 = tmp2 | tmp3; > - if (!ALL_EQ(tmp01 | tmp23, zero)) { > + VECTYPE tmp0 = _mm_or_si128(p[i + 0], p[i + 1]); > + VECTYPE tmp1 = _mm_or_si128(p[i + 2], p[i + 3]); > + VECTYPE tmp2 = _mm_or_si128(p[i + 4], p[i + 5]); > + VECTYPE tmp3 = _mm_or_si128(p[i + 6], p[i + 7]); > + VECTYPE tmp01 = _mm_or_si128(tmp0, tmp1); > + VECTYPE tmp23 = _mm_or_si128(tmp2, tmp3); > + if (!ALL_EQ(_mm_or_si128(tmp01, tmp23), zero)) { > break; > }