From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z74VX-0006mE-Mx for qemu-devel@nongnu.org; Mon, 22 Jun 2015 12:23:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z74VU-0003rC-EX for qemu-devel@nongnu.org; Mon, 22 Jun 2015 12:23:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49119 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z74VU-0003qv-8T for qemu-devel@nongnu.org; Mon, 22 Jun 2015 12:23:36 -0400 Message-ID: <55883686.2090209@suse.de> Date: Mon, 22 Jun 2015 18:23:34 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1434989108-20924-1-git-send-email-den@openvz.org> <1434989108-20924-12-git-send-email-den@openvz.org> In-Reply-To: <1434989108-20924-12-git-send-email-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Andrey Smetanin , Paolo Bonzini , qemu-devel@nongnu.org, kvm@vger.kernel.org, Juan Quintela Am 22.06.2015 um 18:05 schrieb Denis V. Lunev: > From: Andrey Smetanin >=20 > It's usually impossible to understand from Hyper-V > crash msr's that crash happened because ctl msr > always contains the same value HV_X64_MSR_CRASH_CTL_NOTIFY. > To solve it add a particalar value hv_crash_occurred > inside CPU state and migrate this value with crash msr's. >=20 > Signed-off-by: Andrey Smetanin > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Andreas F=C3=A4rber > --- [...] > diff --git a/target-i386/machine.c b/target-i386/machine.c > index 15b3f31..4f72ba8 100644 > --- a/target-i386/machine.c > +++ b/target-i386/machine.c > @@ -679,6 +679,7 @@ static const VMStateDescription vmstate_msr_hyperv_= crash =3D { > VMSTATE_UINT64(env.msr_hv_crash_ctl, X86CPU), > VMSTATE_UINT64_ARRAY(env.msr_hv_crash_prm, > X86CPU, HV_X64_MSR_CRASH_PARAMS), > + VMSTATE_UINT8(env.hv_crash_occurred, X86CPU), > VMSTATE_END_OF_LIST() > } > }; This looks like a migration format breakage. You probably need to squash it with the preceding patch so that the "cpu/msr_hyperv_crash" subsection does not change in size between commits. Just incrementing the version is not an option for subsections, I think? Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)