From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36633)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1Z74hB-0002P0-Db
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 12:35:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1Z74h8-0002Dh-4I
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 12:35:41 -0400
Received: from mx2.parallels.com ([199.115.105.18]:43073)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1Z74h7-0002Bu-UZ
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 12:35:38 -0400
Message-ID: <5588394F.8040809@openvz.org>
Date: Mon, 22 Jun 2015 19:35:27 +0300
From: "Denis V. Lunev" <den@openvz.org>
MIME-Version: 1.0
References: <1434989108-20924-1-git-send-email-den@openvz.org>
	<1434989108-20924-12-git-send-email-den@openvz.org>
	<55883686.2090209@suse.de> <55883760.6010502@redhat.com>
	<558838F6.1080507@suse.de>
In-Reply-To: <558838F6.1080507@suse.de>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that
 hyper-v crash occured
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Andrey Smetanin <asmetanin@virtuozzo.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org, Juan Quintela <quintela@redhat.com>

On 22/06/15 19:33, Andreas Färber wrote:
> Am 22.06.2015 um 18:27 schrieb Paolo Bonzini:
>> On the other hand, I wonder if current_cpu is available in
>> qemu_system_guest_panicked.  If so, you could add the field to the
>> generic CPUState struct and migrate it as a subsection of
>> vmstate_cpu_common.
> Hm, not sure whether it is.
>
> Would that work with the two ways we use vmstate_cpu_common though?
> I.e., can a nested VMState struct (VMSTATE_CPU()) have subsections?
>
> Regards,
> Andreas
>
we'd better squash to avoid troubles. Any other issues?