From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z75oH-0000Jb-34 for qemu-devel@nongnu.org; Mon, 22 Jun 2015 13:47:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z75oC-0001dI-3n for qemu-devel@nongnu.org; Mon, 22 Jun 2015 13:47:05 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52299 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z75oB-0001dC-TP for qemu-devel@nongnu.org; Mon, 22 Jun 2015 13:47:00 -0400 Message-ID: <55884A12.2020806@suse.de> Date: Mon, 22 Jun 2015 19:46:58 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1434989108-20924-1-git-send-email-den@openvz.org> <1434989108-20924-12-git-send-email-den@openvz.org> <55883686.2090209@suse.de> <55883760.6010502@redhat.com> <558838F6.1080507@suse.de> <558839A9.9040009@redhat.com> In-Reply-To: <558839A9.9040009@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Andrey Smetanin , "Denis V. Lunev" , qemu-devel@nongnu.org, kvm@vger.kernel.org, Juan Quintela Am 22.06.2015 um 18:36 schrieb Paolo Bonzini: > On 22/06/2015 18:33, Andreas F=C3=A4rber wrote: >>>> On the other hand, I wonder if current_cpu is available in >>>> qemu_system_guest_panicked. If so, you could add the field to the >>>> generic CPUState struct and migrate it as a subsection of >>>> vmstate_cpu_common. >> Hm, not sure whether it is. >=20 > It should be... Obviously depends on the call site. :) At some point in cpu-exec.c, current_cpu gets set to NULL. So the function would at least deserve a comment on when (not to) use it. Cheers, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)