From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, dgilbert@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/7] error: Make error_setg() a function
Date: Mon, 22 Jun 2015 15:38:56 -0600 [thread overview]
Message-ID: <55888070.2050906@redhat.com> (raw)
In-Reply-To: <1435001200-20610-3-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
On 06/22/2015 01:26 PM, Markus Armbruster wrote:
> Saves a tiny amount of code at every call site.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/qapi/error.h | 4 ++--
> util/error.c | 9 +++++++++
> 2 files changed, 11 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
(Interesting that you turn it back into a macro later in the series...)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-06-22 21:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 19:26 [Qemu-devel] [PATCH 0/7] error: On abort, report where the error was created Markus Armbruster
2015-06-22 19:26 ` [Qemu-devel] [PATCH 1/7] error: De-duplicate code creating Error objects Markus Armbruster
2015-06-22 20:58 ` Eric Blake
2015-06-23 6:57 ` Markus Armbruster
2015-06-22 19:26 ` [Qemu-devel] [PATCH 2/7] error: Make error_setg() a function Markus Armbruster
2015-06-22 21:38 ` Eric Blake [this message]
2015-06-23 7:45 ` Markus Armbruster
2015-06-22 19:26 ` [Qemu-devel] [PATCH 3/7] qga: Clean up unnecessarily dirty casts Markus Armbruster
2015-06-22 22:01 ` Eric Blake
2015-06-23 7:28 ` Markus Armbruster
2015-06-22 19:26 ` [Qemu-devel] [PATCH 4/7] qga/vss-win32: Document the DLL requires non-null errp Markus Armbruster
2015-07-21 15:56 ` Eric Blake
2015-06-22 19:26 ` [Qemu-devel] [PATCH 5/7] error: error_set_errno() is unused, drop Markus Armbruster
2015-07-21 16:05 ` Eric Blake
2015-06-22 19:26 ` [Qemu-devel] [PATCH 6/7] error: Revamp interface documentation Markus Armbruster
2015-07-21 16:11 ` Eric Blake
2015-07-22 13:46 ` Markus Armbruster
2015-06-22 19:26 ` [Qemu-devel] [PATCH 7/7] error: On abort, report where the error was created Markus Armbruster
2015-07-06 20:29 ` Laszlo Ersek
2015-07-21 16:19 ` Eric Blake
2015-07-22 13:54 ` Markus Armbruster
2015-07-22 14:13 ` Eric Blake
2015-07-23 11:22 ` Markus Armbruster
2015-07-06 20:53 ` [Qemu-devel] [PATCH 0/7] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55888070.2050906@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).