From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Z7DhJ-0007Pt-E1
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 22:12:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Z7DhI-0006Zc-Ih
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 22:12:25 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:40093)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Z7DhH-0006Z5-UJ
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 22:12:24 -0400
Message-ID: <5588C080.7070204@huawei.com>
Date: Tue, 23 Jun 2015 10:12:16 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1434646944-24040-1-git-send-email-berrange@redhat.com>
	<1434646944-24040-4-git-send-email-berrange@redhat.com>
In-Reply-To: <1434646944-24040-4-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 03/10] crypto: move built-in D3DES
 implementation into crypto/
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Richard Henderson <rth@twiddle.net>

On 2015/6/19 1:02, Daniel P. Berrange wrote:
> To prepare for a generic internal cipher API, move the
> built-in D3DES implementation into the crypto/ directory.
> 
> This is not in fact a normal D3DES implementation, it is
> D3DES with double & triple length modes removed, and the
> key bytes in reversed bit order. IOW it is crippled
> specifically for the "benefit" of RFB, so call the new
> files desrfb.c instead of d3des.c to make it clear that
> it isn't a generally useful impl.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  crypto/Makefile.objs                  | 1 +
>  ui/d3des.c => crypto/desrfb.c         | 2 +-
>  ui/d3des.h => include/crypto/desrfb.h | 0
>  ui/Makefile.objs                      | 2 +-
>  ui/vnc.c                              | 2 +-
>  5 files changed, 4 insertions(+), 3 deletions(-)
>  rename ui/d3des.c => crypto/desrfb.c (99%)
>  rename ui/d3des.h => include/crypto/desrfb.h (100%)

Reviewed-by: Gonglei <arei.gonglei@huawei.com>