From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33886)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z7KtO-00063z-Pl
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 05:53:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z7KtL-0005z1-L6
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 05:53:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54859)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z7KtL-0005yr-9n
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 05:53:19 -0400
Message-ID: <55892C8A.20601@redhat.com>
Date: Tue, 23 Jun 2015 11:53:14 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1434989108-20924-1-git-send-email-den@openvz.org>
	<1434989108-20924-12-git-send-email-den@openvz.org>
	<55883686.2090209@suse.de> <55883760.6010502@redhat.com>
	<558838F6.1080507@suse.de> <558839A9.9040009@redhat.com>
	<55884A12.2020806@suse.de>
In-Reply-To: <55884A12.2020806@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that
 hyper-v crash occured
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Andrey Smetanin <asmetanin@virtuozzo.com>, "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org, kvm@vger.kernel.org, Juan Quintela <quintela@redhat.com>



On 22/06/2015 19:46, Andreas F=C3=A4rber wrote:
>>>>> >>>> On the other hand, I wonder if current_cpu is available in
>>>>> >>>> qemu_system_guest_panicked.  If so, you could add the field to=
 the
>>>>> >>>> generic CPUState struct and migrate it as a subsection of
>>>>> >>>> vmstate_cpu_common.
>>> >> Hm, not sure whether it is.
>> >=20
>> > It should be...
> Obviously depends on the call site. :) At some point in cpu-exec.c,
> current_cpu gets set to NULL. So the function would at least deserve a
> comment on when (not to) use it.

I think it could be used anyway even if current_cpu.  The difference
would be whether the crash is attached to a CPU or not.

Paolo