From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41836)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mprivozn@redhat.com>) id 1Z7NXF-0001Zx-Fs
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 08:42:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mprivozn@redhat.com>) id 1Z7NXC-0007r5-Ao
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 08:42:41 -0400
Message-ID: <5589543B.1020309@redhat.com>
Date: Tue, 23 Jun 2015 14:42:35 +0200
From: Michal Privoznik <mprivozn@redhat.com>
MIME-Version: 1.0
References: <58e7daaa2977c903b46c3b0dde64e81ce191b5d6.1435062620.git.mprivozn@redhat.com>
	<CAFEAcA_AYg5okJgU61CYQasH9yY8rjsQQxpLq5xPvFyHLtJdgw@mail.gmail.com>
In-Reply-To: <CAFEAcA_AYg5okJgU61CYQasH9yY8rjsQQxpLq5xPvFyHLtJdgw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Makefile: Properly order build targets
 'all' and 'check'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>

On 23.06.2015 14:37, Peter Maydell wrote:
> On 23 June 2015 at 13:30, Michal Privoznik <mprivozn@redhat.com> wrote:
>> I'm used to run 'make -j5 all check'. However, this is not possible in
>> qemu because of the missing dependency in the Makefile. If I do that,
>> tests are usually started with build and since not everything is built
>> yet, they often fail too. Moreover, we should run test suite only
>> after every binary we want to test has been built.
>>
>> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>> ---
>>  Makefile | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile b/Makefile
>> index e7c5c3a..67eeb87 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -151,6 +151,7 @@ dummy := $(call unnest-vars,, \
>>
>>  ifneq ($(wildcard config-host.mak),)
>>  include $(SRC_PATH)/tests/Makefile
>> +check: all
>>  endif
>>  ifeq ($(CONFIG_SMARTCARD_NSS),y)
>>  include $(SRC_PATH)/libcacard/Makefile
> 
> I'm having difficulty understanding the use of conditionals
> in our makefile -- can you explain why inside this ifneq
> rather than outside is the right place for this dependency?

Well, I guess it could be outside too. My thinking was, that we include
the tests/Makefile - which defines the 'check' target - only
conditionally, therefore the dependency should be defined only sometimes
too. I guess it won't hurt if it was outside too.

Michal