qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gonglei <arei.gonglei@huawei.com>
To: Lin Ma <lma@suse.com>, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH V1] Re-attach usb device to kernel while usb_host_open fails
Date: Wed, 24 Jun 2015 11:53:13 +0800	[thread overview]
Message-ID: <558A29A9.8030101@huawei.com> (raw)
In-Reply-To: <1435117141-10459-1-git-send-email-lma@suse.com>

On 2015/6/24 11:39, Lin Ma wrote:
> Changes in V1:
> For avoiding regression issue, Dont remove the usb device from global hostdevs list while
> usb speed mismatch occurs.
> 
> Signed-off-by: Lin Ma <lma@suse.com>
> ---

The changing remarks should be lay up here,
and use v2 suffix instead of v1.

If you do this, you can add my R-by.
	Reviewed-by: Gonglei <arei.gonglei@huawei.com>

Please refer to:
http://wiki.qemu.org/Contribute/SubmitAPatch

Regards,
-Gonglei

>  hw/usb/host-libusb.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
> index bc2944c..11429f5 100644
> --- a/hw/usb/host-libusb.c
> +++ b/hw/usb/host-libusb.c
> @@ -889,6 +889,9 @@ static int usb_host_open(USBHostDevice *s, libusb_device *dev)
>  fail:
>      trace_usb_host_open_failure(bus_num, addr);
>      if (s->dh != NULL) {
> +        usb_host_release_interfaces(s);
> +        libusb_reset_device(s->dh);
> +        usb_host_attach_kernel(s);
>          libusb_close(s->dh);
>          s->dh = NULL;
>          s->dev = NULL;
> 

  reply	other threads:[~2015-06-24  3:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24  3:39 [Qemu-devel] [PATCH V1] Re-attach usb device to kernel while usb_host_open fails Lin Ma
2015-06-24  3:53 ` Gonglei [this message]
2015-06-24  5:35   ` Lin Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558A29A9.8030101@huawei.com \
    --to=arei.gonglei@huawei.com \
    --cc=kraxel@redhat.com \
    --cc=lma@suse.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).