From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7giY-0002br-Pv for qemu-devel@nongnu.org; Wed, 24 Jun 2015 05:11:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7giV-0008Vb-LT for qemu-devel@nongnu.org; Wed, 24 Jun 2015 05:11:38 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:37097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7giV-0008VN-ES for qemu-devel@nongnu.org; Wed, 24 Jun 2015 05:11:35 -0400 Received: by wicgi11 with SMTP id gi11so40041920wic.0 for ; Wed, 24 Jun 2015 02:11:34 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <558A7444.9010806@redhat.com> Date: Wed, 24 Jun 2015 11:11:32 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <3cd46ecda4802e140ac52b2418bbaf915c2fbe67.1433052532.git.crosthwaite.peter@gmail.com> In-Reply-To: <3cd46ecda4802e140ac52b2418bbaf915c2fbe67.1433052532.git.crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Peter Crosthwaite , Pavel Dovgalyuk , edgar.iglesias@gmail.com, afaerber@suse.de, rth@twiddle.net On 31/05/2015 08:11, Peter Crosthwaite wrote: > + /* If not executing code then assume we are ok. */ > + if (cpu->current_tb == NULL) { > + return true; > + } > + return cpu->can_do_io != 0; For what it's worth, I think the "if" here is dead. Pavel? Paolo