From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7gvr-0000Wb-Jc for qemu-devel@nongnu.org; Wed, 24 Jun 2015 05:25:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7gvo-0006DD-Eh for qemu-devel@nongnu.org; Wed, 24 Jun 2015 05:25:23 -0400 Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:37403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7gvo-0006Cq-8E for qemu-devel@nongnu.org; Wed, 24 Jun 2015 05:25:20 -0400 Received: by wicgi11 with SMTP id gi11so40386035wic.0 for ; Wed, 24 Jun 2015 02:25:19 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <558A777C.3090900@redhat.com> Date: Wed, 24 Jun 2015 11:25:16 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <26fe619f01abfe3bedd64733c0500b84675f3f44.1433052532.git.crosthwaite.peter@gmail.com> In-Reply-To: <26fe619f01abfe3bedd64733c0500b84675f3f44.1433052532.git.crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 11/34] include/exec: Move cputlb exec.c defs out List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net, edgar.iglesias@gmail.com, afaerber@suse.de, Peter Crosthwaite On 31/05/2015 08:11, Peter Crosthwaite wrote: > diff --git a/exec.c b/exec.c > index 0cb54f7..71ec173 100644 > --- a/exec.c > +++ b/exec.c > @@ -48,7 +48,6 @@ > #endif > #include "exec/cpu-all.h" > #include "qemu/rcu_queue.h" > -#include "exec/cputlb.h" cputlb.h is still needed in exec.c (e.g. cpu_tlb_reset_dirty_all), so this should not be removed. Paolo > #include "translate-all.h" > > #include "exec/memory-internal.h"