[Qemu-devel] [PATCH] tests: add missing include

[Qemu-devel] [PATCH] tests: add missing include

[Marc-André Lureau]

Fix make test errors of this kind on fedora 22:

linux-test.c:230:19: error: storage size of ‘rusg1’ isn’t known
     struct rusage rusg1, rusg2;

Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
---
 tests/tcg/linux-test.c | 1 +
 tests/tcg/test_path.c  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/tests/tcg/linux-test.c b/tests/tcg/linux-test.c
index 1c6c013..9b3ccc3 100644
--- a/tests/tcg/linux-test.c
+++ b/tests/tcg/linux-test.c
@@ -38,6 +38,7 @@
 #include <sched.h>
 #include <dirent.h>
 #include <setjmp.h>
+#include <sys/resource.h>
 #include <sys/shm.h>
 
 #define TESTPATH "/tmp/linux-test.tmp"
diff --git a/tests/tcg/test_path.c b/tests/tcg/test_path.c
index 1c29bce..edf280c 100644
--- a/tests/tcg/test_path.c
+++ b/tests/tcg/test_path.c
@@ -7,6 +7,7 @@
 #include "util/qemu-timer-common.c"
 #include <stdarg.h>
 #include <sys/stat.h>
+#include <sys/resource.h>
 #include <fcntl.h>
 
 void qemu_log(const char *fmt, ...);
-- 
2.4.2

Re: [Qemu-devel] [PATCH] tests: add missing include

[Andreas Färber]

Am 23.06.2015 um 18:40 schrieb Marc-André Lureau:
> Fix make test errors of this kind on fedora 22:
> 
> linux-test.c:230:19: error: storage size of ‘rusg1’ isn’t known
>      struct rusage rusg1, rusg2;
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
> ---
>  tests/tcg/linux-test.c | 1 +
>  tests/tcg/test_path.c  | 1 +
>  2 files changed, 2 insertions(+)

I believe I already submitted such a patch and more. Peter didn't want
to take them last minute for 2.3 - Peter, can you please reconsider that
now?

Regards,
Andreas

> diff --git a/tests/tcg/linux-test.c b/tests/tcg/linux-test.c
> index 1c6c013..9b3ccc3 100644
> --- a/tests/tcg/linux-test.c
> +++ b/tests/tcg/linux-test.c
> @@ -38,6 +38,7 @@
>  #include <sched.h>
>  #include <dirent.h>
>  #include <setjmp.h>
> +#include <sys/resource.h>
>  #include <sys/shm.h>
>  
>  #define TESTPATH "/tmp/linux-test.tmp"
> diff --git a/tests/tcg/test_path.c b/tests/tcg/test_path.c
> index 1c29bce..edf280c 100644
> --- a/tests/tcg/test_path.c
> +++ b/tests/tcg/test_path.c
> @@ -7,6 +7,7 @@
>  #include "util/qemu-timer-common.c"
>  #include <stdarg.h>
>  #include <sys/stat.h>
> +#include <sys/resource.h>
>  #include <fcntl.h>
>  
>  void qemu_log(const char *fmt, ...);
> 


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH] tests: add missing include

[Peter Maydell]

On 24 June 2015 at 13:39, Andreas Färber <afaerber@suse.de> wrote:
> Am 23.06.2015 um 18:40 schrieb Marc-André Lureau:
>> Fix make test errors of this kind on fedora 22:
>>
>> linux-test.c:230:19: error: storage size of ‘rusg1’ isn’t known
>>      struct rusage rusg1, rusg2;
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
>> ---
>>  tests/tcg/linux-test.c | 1 +
>>  tests/tcg/test_path.c  | 1 +
>>  2 files changed, 2 insertions(+)
>
> I believe I already submitted such a patch and more. Peter didn't want
> to take them last minute for 2.3 - Peter, can you please reconsider that
> now?

...2.3 is long behind us so obviously its time pressures
don't apply now. We're in 2.4 softfreeze right now so bug fixes
like this are certainly OK.

-- PMM