From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7oHm-0004Ta-L4 for qemu-devel@nongnu.org; Wed, 24 Jun 2015 13:16:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7oHj-0001sJ-1w for qemu-devel@nongnu.org; Wed, 24 Jun 2015 13:16:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46989 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7oHi-0001sD-S8 for qemu-devel@nongnu.org; Wed, 24 Jun 2015 13:16:26 -0400 Message-ID: <558AE5E9.7030809@suse.de> Date: Wed, 24 Jun 2015 19:16:25 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <00c96d447252bc1333e14e626611f4f5a58f9bf5.1434432813.git.crosthwaite.peter@gmail.com> <5588466A.1030902@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/4] gdbstub: Use cpu_set_pc helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , Peter Maydell Cc: "Edgar E. Iglesias" , Peter Crosthwaite , "qemu-devel@nongnu.org Developers" , Peter Crosthwaite Am 24.06.2015 um 19:04 schrieb Peter Crosthwaite: > On Wed, Jun 24, 2015 at 3:01 AM, Peter Maydell wrote: >> On 24 June 2015 at 03:50, Peter Crosthwaite >> wrote: >>> On Mon, Jun 22, 2015 at 10:31 AM, Andreas F=C3=A4rber wrote: >>>> I believe this argument will probably go away; otherwise this should= 've >>>> been &error_abort or something instead of NULL. >>>> >>> >>> I'm not sure. As I don't see what is catching the case of a gdb 'c' >>> packet for a CPU that doesn't implement set_pc. I'd rather preserve >>> the existing behaviour, and have the qom wrapper do nothing if it is >>> not implemented. >> >> Well, this is one reason why every CPU needs to implement set_pc... >> >=20 > Well. I guess it works for a common case where a continue doesn't > change the PC? If the debugger doesn't change the PC the "c" should > work even without a set_pc call so we don't want to assert on this > valid use case. Guys, is there any target that does not implement set_pc today? If so, which? I'd rather implement it than carry around the iffery and resulting complications. I quickly counted 17 target-* in my tree and all 17 seemed to show up in git-grep. Can you confirm? Didn't check the latest tilegx series. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)