From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7oOa-0000p4-5Q for qemu-devel@nongnu.org; Wed, 24 Jun 2015 13:23:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7oOW-0004mq-PS for qemu-devel@nongnu.org; Wed, 24 Jun 2015 13:23:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7oOW-0004mm-Ka for qemu-devel@nongnu.org; Wed, 24 Jun 2015 13:23:28 -0400 Message-ID: <558AE78B.90705@redhat.com> Date: Wed, 24 Jun 2015 19:23:23 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1435160084-938-1-git-send-email-alex.bennee@linaro.org> <558AD458.4000905@redhat.com> <87y4j9xbxh.fsf@linaro.org> In-Reply-To: <87y4j9xbxh.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Cc: mttcg@greensocs.com, peter.maydell@linaro.org, Alexander Spyridakis , mark.burton@greensocs.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com On 24/06/2015 19:18, Alex Benn=C3=A9e wrote: >>> >> @@ -196,6 +196,8 @@ void arm_handle_psci_call(ARMCPU *cpu) >>> >> } >>> >> target_cpu_class->set_pc(target_cpu_state, entry); >>> >> =20 >>> >> + qemu_cond_signal(target_cpu_state->halt_cond); >> > >> > That's called qemu_cpu_kick(target_cpu_state). :) The patch should = be >> > acceptable now upstream, I think. > Oh so this might well fail in KVM too? >=20 > The qemu_cpu_kick does a qemu_cond_broadcast(cpu->halt_cond) which seem= s > a little excessive? Won't all sleeping CPUs wake up (and return to slee= p)? On KVM (and I assume on MT-TCG), each CPU has a different halt_cond. Paolo