From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7pXm-0007Gp-De for qemu-devel@nongnu.org; Wed, 24 Jun 2015 14:37:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7pXh-00063h-Es for qemu-devel@nongnu.org; Wed, 24 Jun 2015 14:37:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50795 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7pXh-00063d-8M for qemu-devel@nongnu.org; Wed, 24 Jun 2015 14:37:01 -0400 Message-ID: <558AF8CB.5010409@suse.de> Date: Wed, 24 Jun 2015 20:36:59 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom v3 0/4] qom-cpu: Wrap set_pc hook and use in bootloaders List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, edgar.iglesias@gmail.com, Peter Crosthwaite Am 24.06.2015 um 05:19 schrieb Peter Crosthwaite: > Wrap the CPUClass::set_pc fn hook in a caller helper to reduce > verbosity of calls. Simplify the call from the gdbstub. >=20 > Then use the call to abstract away the PC env fields from the ARM and > Microblaze bootloaders. >=20 > This moves towards the goal of minimising system level code of the CPU > env (and one step closer to common-obj'ing the bootloaders). There's a > long way to go (at least for ARM, not so far for MB), but this is a > small win in that direction. >=20 > This helps with multi-arch where the current thinking is to compile > out the maximum content possible from cpu.h. This removes program > counter definitions from the multi-arch cpu.h compile-in list. >=20 > changed since v2: > drop error argument > misc commit messages tweaks >=20 > changed since v1: > Remove thumb changes >=20 > Peter Crosthwaite (4): > cpu: Add wrapper to the set-pc() hook > gdbstub: Use cpu_set_pc() helper > arm: boot: Use cpu_set_pc() > microblaze: boot: Use cpu_set_pc() Thanks, queued with mentioned code modifications on qom-cpu-next: https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next (This is a purely intermediate staging for the lesser reviewed patches and does not indicate they will miss my belated 2.4 pull.) Regards, Andreas >=20 > dtc | 2 +- > gdbstub.c | 5 +---- > hw/arm/boot.c | 19 +++++++------------ > hw/microblaze/boot.c | 2 +- > include/qom/cpu.h | 17 +++++++++++++++++ > 5 files changed, 27 insertions(+), 18 deletions(-) --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)