* [Qemu-devel] [PATCH] m68k: is_mem is useless
@ 2015-06-23 23:00 Laurent Vivier
2015-06-24 0:24 ` Peter Crosthwaite
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Laurent Vivier @ 2015-06-23 23:00 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Laurent Vivier
Remove is_mem as it is never tested anymore since:
commit bfa50bc2638d877cf2900712b7503be22e8811cb
Author: aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
Date: Tue Nov 18 20:26:41 2008 +0000
Remove premature memop TB terminations (Jan Kiszka)
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
target-m68k/translate.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/target-m68k/translate.c b/target-m68k/translate.c
index 96d75bf..ce1fc92 100644
--- a/target-m68k/translate.c
+++ b/target-m68k/translate.c
@@ -129,7 +129,6 @@ typedef struct DisasContext {
uint32_t fpcr;
struct TranslationBlock *tb;
int singlestep_enabled;
- int is_mem;
TCGv_i64 mactmp;
int done_mac;
} DisasContext;
@@ -179,7 +178,6 @@ static inline TCGv gen_load(DisasContext * s, int opsize, TCGv addr, int sign)
{
TCGv tmp;
int index = IS_USER(s);
- s->is_mem = 1;
tmp = tcg_temp_new_i32();
switch(opsize) {
case OS_BYTE:
@@ -209,7 +207,6 @@ static inline TCGv_i64 gen_load64(DisasContext * s, TCGv addr)
{
TCGv_i64 tmp;
int index = IS_USER(s);
- s->is_mem = 1;
tmp = tcg_temp_new_i64();
tcg_gen_qemu_ldf64(tmp, addr, index);
gen_throws_exception = gen_last_qop;
@@ -220,7 +217,6 @@ static inline TCGv_i64 gen_load64(DisasContext * s, TCGv addr)
static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val)
{
int index = IS_USER(s);
- s->is_mem = 1;
switch(opsize) {
case OS_BYTE:
tcg_gen_qemu_st8(val, addr, index);
@@ -241,7 +237,6 @@ static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val)
static inline void gen_store64(DisasContext *s, TCGv addr, TCGv_i64 val)
{
int index = IS_USER(s);
- s->is_mem = 1;
tcg_gen_qemu_stf64(val, addr, index);
gen_throws_exception = gen_last_qop;
}
@@ -2227,7 +2222,6 @@ DISAS_INSN(fpu)
mask = 0x80;
for (i = 0; i < 8; i++) {
if (ext & mask) {
- s->is_mem = 1;
dest = FREG(i, 0);
if (ext & (1 << 13)) {
/* store */
@@ -2999,7 +2993,6 @@ gen_intermediate_code_internal(M68kCPU *cpu, TranslationBlock *tb,
dc->singlestep_enabled = cs->singlestep_enabled;
dc->fpcr = env->fpcr;
dc->user = (env->sr & SR_S) == 0;
- dc->is_mem = 0;
dc->done_mac = 0;
lj = -1;
num_insns = 0;
--
2.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] m68k: is_mem is useless
2015-06-23 23:00 [Qemu-devel] [PATCH] m68k: is_mem is useless Laurent Vivier
@ 2015-06-24 0:24 ` Peter Crosthwaite
2015-06-24 19:15 ` Thomas Huth
2015-06-24 19:19 ` Peter Maydell
2 siblings, 0 replies; 5+ messages in thread
From: Peter Crosthwaite @ 2015-06-24 0:24 UTC (permalink / raw)
To: Laurent Vivier, qemu-trivial
Cc: Peter Maydell, qemu-devel@nongnu.org Developers
cc trivial.
On Tue, Jun 23, 2015 at 4:00 PM, Laurent Vivier <laurent@vivier.eu> wrote:
> Remove is_mem as it is never tested anymore since:
>
> commit bfa50bc2638d877cf2900712b7503be22e8811cb
> Author: aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
> Date: Tue Nov 18 20:26:41 2008 +0000
>
> Remove premature memop TB terminations (Jan Kiszka)
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target-m68k/translate.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 96d75bf..ce1fc92 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -129,7 +129,6 @@ typedef struct DisasContext {
> uint32_t fpcr;
> struct TranslationBlock *tb;
> int singlestep_enabled;
> - int is_mem;
> TCGv_i64 mactmp;
> int done_mac;
> } DisasContext;
> @@ -179,7 +178,6 @@ static inline TCGv gen_load(DisasContext * s, int opsize, TCGv addr, int sign)
> {
> TCGv tmp;
> int index = IS_USER(s);
> - s->is_mem = 1;
> tmp = tcg_temp_new_i32();
> switch(opsize) {
> case OS_BYTE:
> @@ -209,7 +207,6 @@ static inline TCGv_i64 gen_load64(DisasContext * s, TCGv addr)
> {
> TCGv_i64 tmp;
> int index = IS_USER(s);
> - s->is_mem = 1;
> tmp = tcg_temp_new_i64();
> tcg_gen_qemu_ldf64(tmp, addr, index);
> gen_throws_exception = gen_last_qop;
> @@ -220,7 +217,6 @@ static inline TCGv_i64 gen_load64(DisasContext * s, TCGv addr)
> static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val)
> {
> int index = IS_USER(s);
> - s->is_mem = 1;
> switch(opsize) {
> case OS_BYTE:
> tcg_gen_qemu_st8(val, addr, index);
> @@ -241,7 +237,6 @@ static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val)
> static inline void gen_store64(DisasContext *s, TCGv addr, TCGv_i64 val)
> {
> int index = IS_USER(s);
> - s->is_mem = 1;
> tcg_gen_qemu_stf64(val, addr, index);
> gen_throws_exception = gen_last_qop;
> }
> @@ -2227,7 +2222,6 @@ DISAS_INSN(fpu)
> mask = 0x80;
> for (i = 0; i < 8; i++) {
> if (ext & mask) {
> - s->is_mem = 1;
> dest = FREG(i, 0);
> if (ext & (1 << 13)) {
> /* store */
> @@ -2999,7 +2993,6 @@ gen_intermediate_code_internal(M68kCPU *cpu, TranslationBlock *tb,
> dc->singlestep_enabled = cs->singlestep_enabled;
> dc->fpcr = env->fpcr;
> dc->user = (env->sr & SR_S) == 0;
> - dc->is_mem = 0;
> dc->done_mac = 0;
> lj = -1;
> num_insns = 0;
> --
> 2.4.3
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] m68k: is_mem is useless
2015-06-23 23:00 [Qemu-devel] [PATCH] m68k: is_mem is useless Laurent Vivier
2015-06-24 0:24 ` Peter Crosthwaite
@ 2015-06-24 19:15 ` Thomas Huth
2015-06-24 19:19 ` Peter Maydell
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2015-06-24 19:15 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: qemu-trivial, Peter Maydell
On Wed, 24 Jun 2015 01:00:22 +0200
Laurent Vivier <laurent@vivier.eu> wrote:
> Remove is_mem as it is never tested anymore since:
>
> commit bfa50bc2638d877cf2900712b7503be22e8811cb
> Author: aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
> Date: Tue Nov 18 20:26:41 2008 +0000
>
> Remove premature memop TB terminations (Jan Kiszka)
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target-m68k/translate.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 96d75bf..ce1fc92 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -129,7 +129,6 @@ typedef struct DisasContext {
> uint32_t fpcr;
> struct TranslationBlock *tb;
> int singlestep_enabled;
> - int is_mem;
> TCGv_i64 mactmp;
> int done_mac;
> } DisasContext;
> @@ -179,7 +178,6 @@ static inline TCGv gen_load(DisasContext * s, int opsize, TCGv addr, int sign)
> {
> TCGv tmp;
> int index = IS_USER(s);
> - s->is_mem = 1;
> tmp = tcg_temp_new_i32();
> switch(opsize) {
> case OS_BYTE:
> @@ -209,7 +207,6 @@ static inline TCGv_i64 gen_load64(DisasContext * s, TCGv addr)
> {
> TCGv_i64 tmp;
> int index = IS_USER(s);
> - s->is_mem = 1;
> tmp = tcg_temp_new_i64();
> tcg_gen_qemu_ldf64(tmp, addr, index);
> gen_throws_exception = gen_last_qop;
> @@ -220,7 +217,6 @@ static inline TCGv_i64 gen_load64(DisasContext * s, TCGv addr)
> static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val)
> {
> int index = IS_USER(s);
> - s->is_mem = 1;
> switch(opsize) {
> case OS_BYTE:
> tcg_gen_qemu_st8(val, addr, index);
> @@ -241,7 +237,6 @@ static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val)
> static inline void gen_store64(DisasContext *s, TCGv addr, TCGv_i64 val)
> {
> int index = IS_USER(s);
> - s->is_mem = 1;
> tcg_gen_qemu_stf64(val, addr, index);
> gen_throws_exception = gen_last_qop;
> }
> @@ -2227,7 +2222,6 @@ DISAS_INSN(fpu)
> mask = 0x80;
> for (i = 0; i < 8; i++) {
> if (ext & mask) {
> - s->is_mem = 1;
> dest = FREG(i, 0);
> if (ext & (1 << 13)) {
> /* store */
> @@ -2999,7 +2993,6 @@ gen_intermediate_code_internal(M68kCPU *cpu, TranslationBlock *tb,
> dc->singlestep_enabled = cs->singlestep_enabled;
> dc->fpcr = env->fpcr;
> dc->user = (env->sr & SR_S) == 0;
> - dc->is_mem = 0;
> dc->done_mac = 0;
> lj = -1;
> num_insns = 0;
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] m68k: is_mem is useless
2015-06-23 23:00 [Qemu-devel] [PATCH] m68k: is_mem is useless Laurent Vivier
2015-06-24 0:24 ` Peter Crosthwaite
2015-06-24 19:15 ` Thomas Huth
@ 2015-06-24 19:19 ` Peter Maydell
2015-06-25 7:45 ` Laurent Vivier
2 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2015-06-24 19:19 UTC (permalink / raw)
To: Laurent Vivier; +Cc: QEMU Developers
On 24 June 2015 at 00:00, Laurent Vivier <laurent@vivier.eu> wrote:
> Remove is_mem as it is never tested anymore since:
>
> commit bfa50bc2638d877cf2900712b7503be22e8811cb
> Author: aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
> Date: Tue Nov 18 20:26:41 2008 +0000
>
> Remove premature memop TB terminations (Jan Kiszka)
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
How would you like to handle getting these cleanup patches into master?
If you want to collect up the ones which have got review and send
a pull request with them (sometime next week, maybe), I'm happy to
apply it.
(NB: given release cycle, that applies for the moment to the
ones like this which are relatively simple. We should probably
wait until after 2.4 to start trying to get more significant
changes to target-m68k upstream.)
thanks
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] m68k: is_mem is useless
2015-06-24 19:19 ` Peter Maydell
@ 2015-06-25 7:45 ` Laurent Vivier
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2015-06-25 7:45 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Developers
Le 24/06/2015 21:19, Peter Maydell a écrit :
> On 24 June 2015 at 00:00, Laurent Vivier <laurent@vivier.eu> wrote:
>> Remove is_mem as it is never tested anymore since:
>>
>> commit bfa50bc2638d877cf2900712b7503be22e8811cb
>> Author: aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
>> Date: Tue Nov 18 20:26:41 2008 +0000
>>
>> Remove premature memop TB terminations (Jan Kiszka)
>>
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>
> How would you like to handle getting these cleanup patches into master?
> If you want to collect up the ones which have got review and send
> a pull request with them (sometime next week, maybe), I'm happy to
> apply it.
Thank you. I will.
> (NB: given release cycle, that applies for the moment to the
> ones like this which are relatively simple. We should probably
> wait until after 2.4 to start trying to get more significant
> changes to target-m68k upstream.)
No problem. These patches are waiting for years, they can wait some weeks...
Laurent
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-25 7:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-23 23:00 [Qemu-devel] [PATCH] m68k: is_mem is useless Laurent Vivier
2015-06-24 0:24 ` Peter Crosthwaite
2015-06-24 19:15 ` Thomas Huth
2015-06-24 19:19 ` Peter Maydell
2015-06-25 7:45 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).