From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z83Dx-0001hw-9D for qemu-devel@nongnu.org; Thu, 25 Jun 2015 05:13:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z83Du-0001N9-BR for qemu-devel@nongnu.org; Thu, 25 Jun 2015 05:13:33 -0400 Message-ID: <558BC635.1010602@redhat.com> Date: Thu, 25 Jun 2015 11:13:25 +0200 From: Michal Privoznik MIME-Version: 1.0 References: <58e7daaa2977c903b46c3b0dde64e81ce191b5d6.1435062620.git.mprivozn@redhat.com> <5589543B.1020309@redhat.com> <20150623144917.372248b1@thh440s> <558960A3.5010509@redhat.com> <55899B88.30103@weilnetz.de> <87h9pwxo2a.fsf@blackfin.pond.sub.org> In-Reply-To: <87h9pwxo2a.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Makefile: Properly order build targets 'all' and 'check' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Stefan Weil Cc: QEMU Trivial , Peter Maydell , Thomas Huth , QEMU Developers On 25.06.2015 09:08, Markus Armbruster wrote: > Stefan Weil writes: > >> Am 23.06.2015 um 19:31 schrieb Peter Maydell: >>> On 23 June 2015 at 14:35, Michal Privoznik wrote: >>>> Yeah, that could work too. For some reason I thought that having it >>>> there would result in making 'all' just under tests/. But Now that I >>>> tried it out it works just nicely. >>> Have you tested both "build in the source tree" and "build in >>> a separate directory from the source tree", by the way? >>> >>> thanks >>> -- PMM >> >> Both will work, as the modification only adds a dependency. >> >> Do we care that running "make check" will take longer with this >> patch? Make needs some time to check all dependencies for >> "all", even if nothing has to be done. > > If this bothers us, we could try making it an order-only prerequisite: > > check: | all I'm not sure this is the right approach. What is there to check if nothing has been built? I think this dependency is not order-only. It should be a real dependency. > > https://www.gnu.org/software/make/manual/html_node/Prerequisite-Types.html > >> I feel a little bit uneasy with something depending on all. >> Maybe some day we'll want to include check in the default >> build. Then all would depend on check which depends on > > I agree that depending on the default goal (here: all) isn't nice. > >> all which depends on check and so on. An intermediate >> make target could solve that: >> >> all: full-build >> check: full-build >> full-build: $(DOCS) $(TOOLS) $(HELPERS-y) recurse-all modules Well, if we ever do that, it can be done this way. Or any other way that would be applicable to the code in the future. Michal