From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50289)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Z84Lz-0001GK-2D
	for qemu-devel@nongnu.org; Thu, 25 Jun 2015 06:25:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Z84Lt-00009y-8O
	for qemu-devel@nongnu.org; Thu, 25 Jun 2015 06:25:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50060)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Z84Ec-00051T-9J
	for qemu-devel@nongnu.org; Thu, 25 Jun 2015 06:18:18 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id 2F3A7369920
	for <qemu-devel@nongnu.org>; Thu, 25 Jun 2015 10:18:17 +0000 (UTC)
Message-ID: <558BD564.1010200@redhat.com>
Date: Thu, 25 Jun 2015 12:18:12 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1435078724-27104-1-git-send-email-lersek@redhat.com>
	<87vbec2pdr.fsf@blackfin.pond.sub.org>
In-Reply-To: <87vbec2pdr.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/3] update CMOS for ISA-FDC with
	iobase=0x3f0
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Jan Tomko <jtomko@redhat.com>, John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

On 06/25/15 09:55, Markus Armbruster wrote:
> Laszlo Ersek <lersek@redhat.com> writes:
> 
>> This is (again) for the other pc-q35-2.4 ISA-FDC problem reported by
>> Jan. Addressing comments from Markus.
>>
>> Jan, can you give it another try please? I realize this is getting old
>> pretty quick, so don't bother if you don't want to.
>>
>> Cc: Jan Tomko <jtomko@redhat.com>
>> Cc: John Snow <jsnow@redhat.com>
>> Cc: Markus Armbruster <armbru@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (3):
>>   hw/i386/pc: factor out pc_cmos_init_floppy()
>>   hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS
>>   hw/i386/pc: don't carry FDC from pc_basic_device_init() to
>>     pc_cmos_init()
>>
>>  include/hw/i386/pc.h |   3 +-
>>  hw/i386/pc.c         | 129 ++++++++++++++++++++++++++++++++++++++-------------
>>  hw/i386/pc_piix.c    |   5 +-
>>  hw/i386/pc_q35.c     |   5 +-
>>  4 files changed, 101 insertions(+), 41 deletions(-)
> 
> Matter-of-taste comments on PATCH 3.  Regardless:
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> 

Thanks! I'll try to submit a new version soon, with John's and your R-b
added, in order to address your patch 3 remarks.

Thanks for your reviews.
Laszlo