From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z89O5-0000HW-It for qemu-devel@nongnu.org; Thu, 25 Jun 2015 11:48:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z89O4-0006Op-T6 for qemu-devel@nongnu.org; Thu, 25 Jun 2015 11:48:25 -0400 Sender: Paolo Bonzini Message-ID: <558C22BD.1020404@redhat.com> Date: Thu, 25 Jun 2015 17:48:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <3B3C7431-1003-4AAA-90AF-0E1A154DFBE2@gmail.com> <5589A026.5020800@redhat.com> <455CF92B-58FA-446D-9EB0-42661C23B739@gmail.com> <87pp4kxos3.fsf@blackfin.pond.sub.org> <7B989F99-B95C-4D53-AA2D-29B87634D2BB@gmail.com> In-Reply-To: <7B989F99-B95C-4D53-AA2D-29B87634D2BB@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block.c: fix real cdrom detection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid , Markus Armbruster Cc: Kevin Wolf , Peter Maydell , qemu-devel qemu-devel , Qemu-block On 25/06/2015 17:32, Programmingkid wrote: >> I think we are going to have to agree to disagree. I have never >> used the /dev/sr(0 | 1) devices and don't see how they would be >> effected by this patch. Are you trying to say the /dev/sr(0 | 1) >> devices *should* be handled by this patch? > > Thinking about your question some more, I see what you mean. On Linux > /dev/sr0 refers to the cdrom drive. Also on Linux, the /dev/cdrom > link refers to the /dev/sr0 device file. So if you just use > /dev/cdrom, you are good. Well, that's not how things work. If you do things like that, you end up with a bunch of hacks, not with a decent piece of software. There is support for CD-ROM passthrough on Linux and FreeBSD in block/raw-posix.c. Perhaps the FreeBSD support can be extended to OS X as well. Paolo