From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z89jC-0000B1-KB for qemu-devel@nongnu.org; Thu, 25 Jun 2015 12:10:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z89j6-0007xE-UK for qemu-devel@nongnu.org; Thu, 25 Jun 2015 12:10:14 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56028 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z89j6-0007wD-OK for qemu-devel@nongnu.org; Thu, 25 Jun 2015 12:10:08 -0400 Message-ID: <558C27DF.5090800@suse.de> Date: Thu, 25 Jun 2015 18:10:07 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <4b8fc4d985de6c4f44509b9c47a6152add36d832.1435195913.git.zhugh.fnst@cn.fujitsu.com> <558C2583.1040501@suse.de> <558C2605.2070806@redhat.com> In-Reply-To: <558C2605.2070806@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RESEND PATCH v8 1/4] apic: map APIC's MMIO region at each CPU's address space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: chen.fan.fnst@cn.fujitsu.com, imammedo@redhat.com, Zhu Guihua , ehabkost@redhat.com, izumi.taku@jp.fujitsu.com Am 25.06.2015 um 18:02 schrieb Paolo Bonzini: > On 25/06/2015 18:00, Andreas F=E4rber wrote: >>> - if (!mmio_registered) { >>> - ICCBus *b =3D ICC_BUS(qdev_get_parent_bus(dev)); >>> - memory_region_add_subregion(b->apic_address_space, 0, &s->io= _memory); >>> - mmio_registered =3D true; >>> - } >>> + >>> + root =3D address_space_root_memory_region(cpu->as); >>> + memory_region_add_subregion_overlap(root, >>> + s->apicbase & MSR_IA32_APICB= ASE_BASE, >>> + &s->io_memory, >>> + 0x1000); >>> =20 >=20 > I had already remarked that this patch is wrong. cpu->as is completely > unused on KVM, for example. Ah, then I don't understand this [RESEND]. ;) Either way, not on my plate ATM, it seems. Did you also outline how it is supposed to be done instead? Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)