From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37405)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1Z89l8-0001Iw-6q
	for qemu-devel@nongnu.org; Thu, 25 Jun 2015 12:12:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1Z89l4-0000XO-A7
	for qemu-devel@nongnu.org; Thu, 25 Jun 2015 12:12:14 -0400
Message-ID: <558C2852.3050102@redhat.com>
Date: Thu, 25 Jun 2015 18:12:02 +0200
From: Laurent Vivier <lvivier@redhat.com>
MIME-Version: 1.0
References: <3B3C7431-1003-4AAA-90AF-0E1A154DFBE2@gmail.com>	<5589A026.5020800@redhat.com>	<455CF92B-58FA-446D-9EB0-42661C23B739@gmail.com>	<87pp4kxos3.fsf@blackfin.pond.sub.org>	<F7DAD769-DBD2-42E5-89C2-A73D35940F6D@gmail.com>	<7B989F99-B95C-4D53-AA2D-29B87634D2BB@gmail.com>
	<558C22BD.1020404@redhat.com>
In-Reply-To: <558C22BD.1020404@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block.c: fix real cdrom detection
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Programmingkid <programmingkidx@gmail.com>, Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, qemu-devel qemu-devel <qemu-devel@nongnu.org>, Qemu-block <qemu-block@nongnu.org>



On 25/06/2015 17:48, Paolo Bonzini wrote:
> 
> On 25/06/2015 17:32, Programmingkid wrote:
>>> I think we are going to have to agree to disagree. I have never
>>> used the /dev/sr(0 | 1) devices and don't see how they would be
>>> effected by this patch. Are you trying to say the /dev/sr(0 | 1)
>>> devices *should* be handled by this patch?
>>
>> Thinking about your question some more, I see what you mean. On Linux
>> /dev/sr0 refers to the cdrom drive. Also on Linux, the /dev/cdrom
>> link refers to the /dev/sr0 device file. So if you just use
>> /dev/cdrom, you are good.
> 
> Well, that's not how things work.
> 
> If you do things like that, you end up with a bunch of hacks, not with a
> decent piece of software.
> 
> There is support for CD-ROM passthrough on Linux and FreeBSD in
> block/raw-posix.c.  Perhaps the FreeBSD support can be extended to OS X
> as well.
> 

In fact, programmingkid, you should fix it in hdev_open() where there is
already a #if __APPLE__ .

Paolo, I agree with you but :

hdev_open()

#if defined(__linux__)
    {
        char resolved_path[ MAXPATHLEN ], *temp;

        temp = realpath(filename, resolved_path);
        if (temp && strstart(temp, "/dev/sg", NULL)) {
            bs->sg = 1;
        }
#endif

I'm wondering who had this strange idea... :)

Laurent