From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8E7z-00068I-7M for qemu-devel@nongnu.org; Thu, 25 Jun 2015 16:52:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8E7v-0003hF-47 for qemu-devel@nongnu.org; Thu, 25 Jun 2015 16:52:07 -0400 Sender: Paolo Bonzini Message-ID: <558C69EF.30502@redhat.com> Date: Thu, 25 Jun 2015 22:51:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <3B3C7431-1003-4AAA-90AF-0E1A154DFBE2@gmail.com> <5589A026.5020800@redhat.com> <455CF92B-58FA-446D-9EB0-42661C23B739@gmail.com> <87pp4kxos3.fsf@blackfin.pond.sub.org> <7B989F99-B95C-4D53-AA2D-29B87634D2BB@gmail.com> <558C22BD.1020404@redhat.com> <558C2852.3050102@redhat.com> <558C295C.2030108@redhat.com> <36338796-7F34-4D61-A5F8-EF0D0456D7B7@gmail.com> In-Reply-To: <36338796-7F34-4D61-A5F8-EF0D0456D7B7@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block.c: fix real cdrom detection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid Cc: Laurent Vivier , Kevin Wolf , Qemu-block , Peter Maydell , Markus Armbruster , qemu-devel qemu-devel On 25/06/2015 20:07, Programmingkid wrote: > I honestly think it is in the right place. The function find_image_format() > is doing just that - trying to find the format. The image part of the function's name > does bother me. But we could ignore it. Since we know it is a real cdrom drive, > it would receive the format of raw. It seems as simple as that. But matching against the name in generic block.c code is just wrong. It _is_ as simple as that. Paolo