From: Paolo Bonzini <pbonzini@redhat.com>
To: "Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Cc: chen.fan.fnst@cn.fujitsu.com, izumi.taku@jp.fujitsu.com,
Zhu Guihua <zhugh.fnst@cn.fujitsu.com>,
qemu-devel@nongnu.org, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler
Date: Fri, 26 Jun 2015 12:05:05 +0200 [thread overview]
Message-ID: <558D23D1.9020204@redhat.com> (raw)
In-Reply-To: <20150626111941.4faf51f0@nial.brq.redhat.com>
On 26/06/2015 11:19, Igor Mammedov wrote:
> That's one of the reasons, I've asked to get rid of icc-bus.
>
> Another reason is to move default APIC MMIO mapping to CPU from board
> and handle region remapping from CPU itself as it's supposed to be if CPU
> would program another APIC base.
>
> Paolo,
> would following change be acceptable:
>
> x86_cpu_realize() {
> if (tcg) {
> memory_region_add_subregion_overlap(cpu->as, apic->mr)
> } else {
> if (map_once)
> memory_region_add_subregion_overlap(get_system_memory(), apic->mr)
> }
> }
> still a hack but a localized to CPU
Yes, this is better.
Paolo
next prev parent reply other threads:[~2015-06-26 10:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 2:17 [Qemu-devel] [RESEND PATCH v8 0/4] remove icc bus/bridge Zhu Guihua
2015-06-25 2:17 ` [Qemu-devel] [RESEND PATCH v8 1/4] apic: map APIC's MMIO region at each CPU's address space Zhu Guihua
2015-06-25 16:00 ` Andreas Färber
2015-06-25 16:02 ` Paolo Bonzini
2015-06-25 16:10 ` Andreas Färber
2015-06-25 17:02 ` Paolo Bonzini
2015-06-25 17:08 ` Andreas Färber
2015-06-25 17:27 ` Paolo Bonzini
2015-06-25 17:32 ` Peter Maydell
2015-06-25 17:39 ` Paolo Bonzini
2015-06-26 9:01 ` Igor Mammedov
2015-06-26 9:05 ` Paolo Bonzini
2015-06-25 2:17 ` [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler Zhu Guihua
2015-06-25 16:57 ` Andreas Färber
2015-06-25 17:00 ` Paolo Bonzini
2015-06-25 17:28 ` Andreas Färber
2015-06-26 9:19 ` Igor Mammedov
2015-06-26 10:05 ` Paolo Bonzini [this message]
2015-06-30 6:31 ` Zhu Guihua
2015-06-30 9:21 ` Igor Mammedov
2015-06-30 10:50 ` Zhu Guihua
2015-06-30 10:55 ` Peter Maydell
2015-06-30 18:38 ` Eduardo Habkost
2015-06-30 10:24 ` Andreas Färber
2015-06-30 18:30 ` Eduardo Habkost
2015-06-25 2:17 ` [Qemu-devel] [RESEND PATCH v8 3/4] cpu/apic: drop icc bus/bridge Zhu Guihua
2015-06-25 16:44 ` Andreas Färber
2015-06-25 2:17 ` [Qemu-devel] [RESEND PATCH v8 4/4] icc_bus: drop the unused files Zhu Guihua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558D23D1.9020204@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).